Merge branch '281449-feature-flag-enable-environment-auto-stop-start-on-create' into 'master'

Resolve "[Feature flag] Enable environment auto-stop start on create"

See merge request gitlab-org/gitlab!47702

changelogs/unreleased/281449-feature-flag-enable-environment-auto-stop-start-on-create.yml

+---
+title: Begin auto-stop countdown for environment after initial creation
+merge_request: 47702
+author:
+type: changed

config/feature_flags/development/environment_auto_stop_start_on_create.yml

----
-name: environment_auto_stop_start_on_create
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/47239
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/281449
-milestone: '13.6'
-type: development
-group: group::release
-default_enabled: false

lib/gitlab/ci/pipeline/seed/environment.rb

@@ -24,9 +24,7 @@ module Gitlab
           end
 
           def auto_stop_in
-            if Feature.enabled?(:environment_auto_stop_start_on_create)
-              job.environment_auto_stop_in
-            end
+            job.environment_auto_stop_in
           end
 
           def expanded_environment_name

spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb

@@ -85,16 +85,6 @@ RSpec.describe Gitlab::Ci::Pipeline::Seed::Environment do
         end
 
         it_behaves_like 'returning a correct environment'
-
-        context 'but the environment auto_stop_in on create flag is disabled' do
-          let(:expected_auto_stop_in) { nil }
-
-          before do
-            stub_feature_flags(environment_auto_stop_start_on_create: false)
-          end
-
-          it_behaves_like 'returning a correct environment'
-        end
       end
     end