Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
6511e9fd
Commit
6511e9fd
authored
Apr 21, 2021
by
jboyson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update to be more ARIA friendly
parent
5de0770a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
10 deletions
+14
-10
app/assets/javascripts/diffs/components/diff_row.vue
app/assets/javascripts/diffs/components/diff_row.vue
+14
-10
No files found.
app/assets/javascripts/diffs/components/diff_row.vue
View file @
6511e9fd
...
...
@@ -157,8 +157,8 @@ export default {
table
.
classList
.
add
(
`
${
lineClass
}
-selected`
);
}
},
handleCommentButton
(
line
)
{
this
.
showCommentForm
({
lineCode
:
line
.
line_code
,
fileHash
:
this
.
fileHash
});
handleCommentButton
(
line
,
disabled
)
{
if
(
!
disabled
)
this
.
showCommentForm
({
lineCode
:
line
.
line_code
,
fileHash
:
this
.
fileHash
});
},
conflictText
(
line
)
{
return
line
.
type
===
CONFLICT_MARKER_THEIR
...
...
@@ -223,10 +223,10 @@ export default {
class=
"add-diff-note unified-diff-components-diff-note-button note-button js-add-diff-note-button qa-diff-comment"
data-qa-selector=
"diff_comment_button"
:class=
"
{ 'gl-cursor-grab': dragging }"
:disabled="line.left.commentsDisabled"
@click="handleCommentButton(line.left)"
@keydown.enter="handleCommentButton(line.left)"
@keydown.space="handleCommentButton(line.left)"
:
aria-
disabled="line.left.commentsDisabled"
@click="handleCommentButton(line.left
, line.left.commentsDisabled
)"
@keydown.enter="handleCommentButton(line.left
, line.left.commentsDisabled
)"
@keydown.space="handleCommentButton(line.left
, line.left.commentsDisabled
)"
@dragstart="onDragStart({ ...line.left, index })"
>
</div>
</span>
...
...
@@ -321,15 +321,19 @@ export default {
class=
"add-diff-note tooltip-wrapper"
:title=
"addCommentTooltipRight"
>
<button
<div
role=
"button"
tabindex=
"0"
:draggable=
"glFeatures.dragCommentSelection"
type=
"button"
class=
"add-diff-note unified-diff-components-diff-note-button note-button js-add-diff-note-button qa-diff-comment"
:class=
"
{ 'gl-cursor-grab': dragging }"
:disabled="line.right.commentsDisabled"
@click="handleCommentButton(line.right)"
:aria-disabled="line.right.commentsDisabled"
@click="handleCommentButton(line.right, line.right.commentsDisabled)"
@keydown.enter="handleCommentButton(line.right, line.right.commentsDisabled)"
@keydown.space="handleCommentButton(line.right, line.right.commentsDisabled)"
@dragstart="onDragStart({ ...line.right, index })"
>
</
button
>
>
</
div
>
</span>
</
template
>
<a
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment