Update password change sign-in banner text

GitLab prefers using `sign-in` rather than `login`. The banner
shown to users after they change their password contains the word
`login`, and the grammar is also less than ideal. This change
updates the text to be more gramattically correct and uses the word
`sign-in` instead of `login`.

app/controllers/profiles/passwords_controller.rb

@@ -52,7 +52,7 @@ class Profiles::PasswordsController < Profiles::ApplicationController
     result = Users::UpdateService.new(current_user, password_attributes.merge(user: @user)).execute
 
     if result[:status] == :success
-      flash[:notice] = _('Password was successfully updated. Please login with it')
+      flash[:notice] = _('Password was successfully updated. Please sign in again.')
       redirect_to new_user_session_path
     else
       @user.reset

changelogs/unreleased/dblessing-update-pw-change-banner.yml

+---
+title: Update password change sign-in banner text
+merge_request: 38606
+author:
+type: fixed

locale/gitlab.pot

@@ -17194,7 +17194,7 @@ msgstr ""
 msgid "Password successfully changed"
 msgstr ""
 
-msgid "Password was successfully updated. Please login with it"
+msgid "Password was successfully updated. Please sign in again."
 msgstr ""
 
 msgid "Passwords should be unique and not used for any other sites or services."

spec/features/profiles/password_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe 'Profile > Password' do
           fill_passwords('mypassword', 'mypassword')
 
           page.within('.flash-notice') do
-            expect(page).to have_content('Password was successfully updated. Please login with it')
+            expect(page).to have_content('Password was successfully updated. Please sign in again.')
           end
         end
       end