Merge branch 'sy-update-security-discovery-feedback-cta' into 'master'

Change security discovery feedback icon to button

See merge request gitlab-org/gitlab!76120

ee/app/assets/javascripts/vue_shared/discover/card_security_discover_app.vue

@@ -86,7 +86,7 @@ export default {
     discoverTitle: s__(
       'Discover|Security capabilities, integrated into your development lifecycle',
     ),
-    discoverFeedbackLabel: s__('Discover|Give feedback for this page'),
+    discoverFeedbackLabel: s__('Discover|Send feedback'),
     discoverUpgradeLabel: s__('Discover|Upgrade now'),
     discoverTrialLabel: s__('Discover|Start a free trial'),
     carouselCaptions: [
@@ -182,12 +182,7 @@ export default {
     </div>
     <div id="tooltipcontainer" class="discover-feedback gl-fixed">
       <gl-button
-        v-gl-tooltip:tooltipcontainer.left
-        :title="$options.i18n.discoverFeedbackLabel"
-        :aria-label="$options.i18n.discoverFeedbackLabel"
-        icon="slight-smile"
-        size="medium"
-        class="discover-feedback-icon"
+        class="discover-button-feedback"
         category="secondary"
         variant="default"
         target="_blank"
@@ -196,7 +191,9 @@ export default {
         data-track-label="security-discover-feedback-cta"
         :data-track-property="slide"
         :href="linkFeedback"
-      />
+      >
+        {{ $options.i18n.discoverFeedbackLabel }}
+      </gl-button>
     </div>
   </div>
 </template>

ee/spec/frontend/vue_shared/discover/card_security_discover_app_spec.js

@@ -39,10 +39,8 @@ describe('Card security discover app', () => {
       );
     });
 
-    it('renders feedback icon link properly', () => {
-      expect(wrapper.find('.discover-feedback-icon').html()).toContain(
-        'Give feedback for this page',
-      );
+    it('renders discover feedback link properly', () => {
+      expect(wrapper.find('.discover-button-feedback').html()).toContain('Send feedback');
     });
 
     it('renders discover upgrade links properly', () => {
@@ -91,7 +89,7 @@ describe('Card security discover app', () => {
       });
 
       it('tracks an event when clicked on feedback', () => {
-        wrapper.find('.discover-feedback-icon').trigger('click');
+        wrapper.find('.discover-button-feedback').trigger('click');
 
         expect(spy).toHaveBeenCalledWith('_category_', 'click_button', {
           label: 'security-discover-feedback-cta',

locale/gitlab.pot

@@ -12381,15 +12381,15 @@ msgstr ""
 msgid "Discover|GitLab will perform static and dynamic tests on the code of your application, looking for known flaws and report them in the merge request so you can fix them before merging."
 msgstr ""
 
-msgid "Discover|Give feedback for this page"
-msgstr ""
-
 msgid "Discover|Security capabilities, integrated into your development lifecycle"
 msgstr ""
 
 msgid "Discover|See the other features of the %{linkStart}ultimate plan%{linkEnd}"
 msgstr ""
 
+msgid "Discover|Send feedback"
+msgstr ""
+
 msgid "Discover|Start a free trial"
 msgstr ""