Merge branch 'xanf-fix-saml-settings-form' into 'master'

Resolve "SAML/SSO/GMA toggles appear disabled when they're not"

Closes #211695

See merge request gitlab-org/gitlab!28126

ee/app/assets/javascripts/saml_providers/saml_settings_form.js

@@ -114,16 +114,16 @@ export default class SamlSettingsForm {
       .filter(setting => setting.dependsOn)
       .forEach(setting => {
         const { helperText, callout, toggle } = setting;
-        const dependentToggleValue = this.getValueWithDeps(setting.dependsOn);
+        const isRelatedToggleOn = this.getValueWithDeps(setting.dependsOn);
         if (helperText) {
-          helperText.style.display = dependentToggleValue ? 'none' : 'block';
+          helperText.style.display = isRelatedToggleOn ? 'none' : 'block';
         }
 
-        toggle.classList.toggle('is-disabled', dependentToggleValue);
-        toggle.disabled = !dependentToggleValue;
+        toggle.classList.toggle('is-disabled', !isRelatedToggleOn);
+        toggle.disabled = !isRelatedToggleOn;
 
         if (callout) {
-          callout.style.display = setting.value && dependentToggleValue ? 'block' : 'none';
+          callout.style.display = setting.value && isRelatedToggleOn ? 'block' : 'none';
         }
       });
   }

ee/spec/frontend/saml_providers/saml_settings_form_spec.js

@@ -54,12 +54,14 @@ describe('SamlSettingsForm', () => {
     samlSettingsForm.updateSAMLSettings();
     samlSettingsForm.updateView();
     expect(findProhibitForksSetting().toggle.hasAttribute('disabled')).toBe(false);
+    expect(findProhibitForksSetting().toggle.classList.contains('is-disabled')).toBe(false);
 
     findEnforcedGroupManagedAccountSetting().input.value = false;
     samlSettingsForm.updateSAMLSettings();
     samlSettingsForm.updateView();
 
     expect(findProhibitForksSetting().toggle.hasAttribute('disabled')).toBe(true);
+    expect(findProhibitForksSetting().toggle.classList.contains('is-disabled')).toBe(true);
     expect(findProhibitForksSetting().value).toBe(true);
   });