Merge branch '9083-epics-autocomplete-milestones-in-public-groups' into 'master'

Include public group milestones in epics autocomplete

Closes #9083

See merge request gitlab-org/gitlab-ee!9068

ee/app/finders/parent_groups_finder.rb

-# frozen_string_literal: true
-
-class ParentGroupsFinder
-  attr_accessor :user, :group
-
-  def initialize(user, group)
-    @group = group
-    @user = user
-  end
-
-  # rubocop: disable CodeReuse/ActiveRecord
-  def execute
-    group.self_and_ancestors.where(id: user&.authorized_groups)
-  end
-  # rubocop: enable CodeReuse/ActiveRecord
-end

ee/app/services/groups/autocomplete_service.rb

@@ -34,12 +34,13 @@ module Groups
       end
     end
 
+    # rubocop: disable CodeReuse/ActiveRecord
     def milestones
-      group_ids =
-        ParentGroupsFinder.new(current_user, group).execute.map(&:id)
+      group_ids = group.self_and_ancestors.public_or_visible_to_user(current_user).pluck(:id)
 
       MilestonesFinder.new(group_ids: group_ids).execute.select(:iid, :title)
     end
+    # rubocop: enable CodeReuse/ActiveRecord
 
     def labels_as_hash(target)
       super(target, group_id: group.id, only_group_labels: true)

ee/changelogs/unreleased/9083-epics-autocomplete-milestones-in-public-groups.yml

+---
+title: Fix public group milestones not shown in epics autocomplete
+merge_request: 9068
+author:
+type: fixed

ee/spec/services/groups/autocomplete_service_spec.rb

@@ -122,9 +122,6 @@ describe Groups::AutocompleteService do
       let(:public_subgroup) { create(:group, :public, parent: public_group) }
 
       before do
-        public_subgroup.add_guest(user)
-        public_group.add_guest(user)
-
         group_milestone.update(group: public_group)
         subgroup_milestone.update(group: public_subgroup)
       end