Merge branch 're-enable_boards_negative_filters' into 'master'

Re-enable negative filters for Boards

See merge request gitlab-org/gitlab!32348

app/controllers/boards/issues_controller.rb

@@ -20,9 +20,6 @@ module Boards
     skip_before_action :authenticate_user!, only: [:index]
     before_action :validate_id_list, only: [:bulk_move]
     before_action :can_move_issues?, only: [:bulk_move]
-    before_action do
-      push_frontend_feature_flag(:not_issuable_queries, board.group, default_enabled: true)
-    end
 
     def index
       list_service = Boards::Issues::ListService.new(board_parent, current_user, filter_params)

app/controllers/concerns/boards_actions.rb

@@ -10,6 +10,9 @@ module BoardsActions
     before_action :boards, only: :index
     before_action :board, only: :show
     before_action :push_wip_limits, only: [:index, :show]
+    before_action do
+      push_frontend_feature_flag(:not_issuable_queries, parent, default_enabled: true)
+    end
   end
 
   def index

changelogs/unreleased/re-enable_boards_negative_filters.yml

+---
+title: Re-enable negative filters for Boards
+merge_request: 32348
+author:
+type: fixed

spec/features/boards/boards_spec.rb

@@ -137,6 +137,49 @@ describe 'Issue Boards', :js do
       expect(find('.board:nth-child(4)')).to have_selector('.board-card', count: 0)
     end
 
+    context 'search list negation queries' do
+      context 'with the NOT queries feature flag disabled' do
+        before do
+          stub_feature_flags(not_issuable_queries: false)
+          visit project_board_path(project, board)
+        end
+
+        it 'does not have the != option' do
+          find('.filtered-search').set('label:')
+
+          wait_for_requests
+          within('#js-dropdown-operator') do
+            tokens = all(:css, 'li.filter-dropdown-item')
+            expect(tokens.count).to eq(1)
+            button = tokens[0].find('button')
+            expect(button).to have_content('=')
+            expect(button).not_to have_content('!=')
+          end
+        end
+      end
+
+      context 'with the NOT queries feature flag enabled' do
+        before do
+          stub_feature_flags(not_issuable_queries: true)
+          visit project_board_path(project, board)
+        end
+
+        it 'does not have the != option' do
+          find('.filtered-search').set('label:')
+
+          wait_for_requests
+          within('#js-dropdown-operator') do
+            tokens = all(:css, 'li.filter-dropdown-item')
+            expect(tokens.count).to eq(2)
+            button = tokens[0].find('button')
+            expect(button).to have_content('=')
+            button = tokens[1].find('button')
+            expect(button).to have_content('!=')
+          end
+        end
+      end
+    end
+
     it 'allows user to delete board' do
       page.within(find('.board:nth-child(2)')) do
         accept_confirm { find('.board-delete').click }