Stop closing issue edit form in error state

app/assets/javascripts/issue_show/components/app.vue

@@ -270,7 +270,6 @@ export default {
               errMsg += `. ${response.data.errors.join(' ')}`;
             }
 
-            eventHub.$emit('close.form');
             createFlash(errMsg);
           }
         });
@@ -295,7 +294,6 @@ export default {
           visitUrl(data.web_url);
         })
         .catch(() => {
-          eventHub.$emit('close.form');
           createFlash(
             sprintf(s__('Error deleting  %{issuableType}'), { issuableType: this.issuableType }),
           );

spec/javascripts/issue_show/components/app_spec.js

@@ -263,11 +263,11 @@ describe('Issuable output', () => {
 
     describe('error when updating', () => {
       it('closes form on error', done => {
-        spyOn(vm.service, 'updateIssuable').and.callFake(() => Promise.resolve());
+        spyOn(vm.service, 'updateIssuable').and.callFake(() => Promise.reject());
         vm.updateIssuable();
 
         setTimeout(() => {
-          expect(eventHub.$emit).toHaveBeenCalledWith('close.form');
+          expect(eventHub.$emit).not.toHaveBeenCalledWith('close.form');
           expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
             `Error updating issue`,
           );
@@ -284,7 +284,7 @@ describe('Issuable output', () => {
           vm.updateIssuable();
 
           setTimeout(() => {
-            expect(eventHub.$emit).toHaveBeenCalledWith('close.form');
+            expect(eventHub.$emit).not.toHaveBeenCalledWith('close.form');
             expect(document.querySelector('.flash-container .flash-text').innerText.trim()).toBe(
               `Error updating merge request`,
             );