Don't show "allowed to fail" tag on successful jobs

When a job is done and has passed, seeing the
"allowed to fail" tag is confusing so we are
removing it in this instance.

app/views/projects/ci/builds/_build.html.haml

@@ -45,7 +45,7 @@
             = tag
       - if job.try(:trigger_request)
         %span.badge.badge-info= _('triggered')
-      - if job.try(:allow_failure)
+      - if job.try(:allow_failure) && !job.success?
         %span.badge.badge-warning= _('allowed to fail')
       - if job.schedulable?
         %span.badge.badge-info= s_('DelayedJobs|delayed')

changelogs/unreleased/198052-in-the-jobs-page-the-allowed-to-fail-badge-looks-like-an-error.yml

+---
+title: Hides the "Allowed to fail" tag on jobs that are successful
+merge_request: 25458
+author:
+type: changed