Merge branch '239838-cleanup-suggestion-help-hover' into 'master'

Cleanup .suggestion-help-hover classes

See merge request gitlab-org/gitlab!72132

app/assets/javascripts/issuable_suggestions/components/app.vue

@@ -74,7 +74,7 @@ export default {
         :title="$options.helpText"
         :aria-label="$options.helpText"
         name="question-o"
-        class="text-secondary suggestion-help-hover"
+        class="text-secondary gl-cursor-help"
       />
     </div>
     <div class="col-sm-10">

app/assets/stylesheets/pages/issuable.scss

@@ -877,10 +877,6 @@
   vertical-align: sub;
 }
 
-.suggestion-help-hover {
-  cursor: help;
-}
-
 .suggestion-footer {
   font-size: 12px;
   line-height: 15px;

app/views/projects/deployments/_deployment.html.haml

@@ -27,7 +27,7 @@
             = link_to deployment_path(deployment), class: 'build-link' do
               #{deployment.deployable.name} (##{deployment.deployable.id})
     - else
-      .badge.badge-info.suggestion-help-hover{ title: s_('Deployment|This deployment was created using the API') }
+      .badge.badge-info.gl-cursor-help{ title: s_('Deployment|This deployment was created using the API') }
         = s_('Deployment|API')
 
   .table-section.section-10{ role: 'gridcell' }

ee/app/assets/javascripts/approvals/components/approval_check_popover.vue

@@ -42,7 +42,7 @@ export default {
     <gl-icon
       :id="popoverTriggerId"
       name="question"
-      class="author-link suggestion-help-hover"
+      class="author-link gl-cursor-help"
       :aria-label="__('help')"
       :size="14"
       data-testid="icon2"

ee/app/assets/javascripts/approvals/components/empty_rule_name.vue

@@ -27,7 +27,7 @@ export default {
         name="question"
         :aria-label="__('help')"
         :size="14"
-        class="author-link suggestion-help-hover"
+        class="author-link gl-cursor-help"
       />
       <gl-popover target="pop-approver" container="popovercontainer" placement="top">
         <template #title>{{ __('Who can approve?') }}</template>

ee/app/assets/javascripts/approvals/components/rule_name.vue

@@ -71,7 +71,7 @@ export default {
         name="question"
         :aria-label="__('Help')"
         :size="14"
-        class="author-link suggestion-help-hover"
+        class="author-link gl-cursor-help"
       />
       <gl-popover :target="popoverTarget" placement="top">
         <template #title>{{ __('Who can approve?') }}</template>