Commit 71025210 authored by DJ Mountney's avatar DJ Mountney

Move qa test use of refresh selector into the job page

parent 19ac6bad
...@@ -6,6 +6,7 @@ module QA::Page ...@@ -6,6 +6,7 @@ module QA::Page
view 'app/views/shared/builds/_build_output.html.haml' do view 'app/views/shared/builds/_build_output.html.haml' do
element :build_output, '.js-build-output' element :build_output, '.js-build-output'
element :loading_animation, '.js-build-refresh'
end end
view 'app/assets/javascripts/vue_shared/components/ci_badge_link.vue' do view 'app/assets/javascripts/vue_shared/components/ci_badge_link.vue' do
...@@ -20,6 +21,10 @@ module QA::Page ...@@ -20,6 +21,10 @@ module QA::Page
find('.ci-status').text == PASSED_STATUS find('.ci-status').text == PASSED_STATUS
end end
def trace_loading?
has_css?('.js-build-refresh')
end
# Reminder: You may wish to wait for a particular job status before checking output # Reminder: You may wish to wait for a particular job status before checking output
def output def output
find('.js-build-output').text find('.js-build-output').text
......
...@@ -93,7 +93,7 @@ module QA ...@@ -93,7 +93,7 @@ module QA
Page::Project::Job::Show.perform do |job| Page::Project::Job::Show.perform do |job|
job.wait(reload: false) do job.wait(reload: false) do
job.completed? && !job.has_css?('.js-build-refresh') job.completed? && !job.trace_loading?
end end
expect(job.passed?).to be_truthy, "Job status did not become \"passed\"." expect(job.passed?).to be_truthy, "Job status did not become \"passed\"."
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment