Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
710d0435
Commit
710d0435
authored
Jul 27, 2017
by
Tim Zallmann
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Changed Images in Blob Viewer to image_tag
Updated documentation about the lazy class
parent
14b9c83f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
10 deletions
+11
-10
app/views/projects/blob/viewers/_image.html.haml
app/views/projects/blob/viewers/_image.html.haml
+1
-1
app/views/projects/diffs/viewers/_image.html.haml
app/views/projects/diffs/viewers/_image.html.haml
+7
-7
doc/development/fe_guide/performance.md
doc/development/fe_guide/performance.md
+3
-2
No files found.
app/views/projects/blob/viewers/_image.html.haml
View file @
710d0435
.file-content.image_file
.file-content.image_file
%img
.lazy
{
'data-src'
:
blob_raw_url
,
alt:
viewer
.
blob
.
name
}
=
image_tag
(
blob_raw_url
,
alt:
viewer
.
blob
.
name
)
app/views/projects/diffs/viewers/_image.html.haml
View file @
710d0435
...
@@ -8,7 +8,7 @@
...
@@ -8,7 +8,7 @@
.image
.image
%span
.wrap
%span
.wrap
.frame
{
class:
(
diff_file
.
deleted_file?
?
'deleted'
:
'added'
)
}
.frame
{
class:
(
diff_file
.
deleted_file?
?
'deleted'
:
'added'
)
}
%img
.lazy
{
'data-src'
:
blob_raw_path
,
alt:
diff_file
.
file_path
}
=
image_tag
(
blob_raw_path
,
alt:
diff_file
.
file_path
)
%p
.image-info
=
number_to_human_size
(
blob
.
size
)
%p
.image-info
=
number_to_human_size
(
blob
.
size
)
-
else
-
else
.image
.image
...
@@ -16,7 +16,7 @@
...
@@ -16,7 +16,7 @@
%span
.wrap
%span
.wrap
.frame.deleted
.frame.deleted
%a
{
href:
project_blob_path
(
@project
,
tree_join
(
diff_file
.
old_content_sha
,
diff_file
.
old_path
))
}
%a
{
href:
project_blob_path
(
@project
,
tree_join
(
diff_file
.
old_content_sha
,
diff_file
.
old_path
))
}
%img
.lazy
{
'data-src'
:
old_blob_raw_path
,
alt:
diff_file
.
old_path
}
=
image_tag
(
old_blob_raw_path
,
alt:
diff_file
.
old_path
)
%p
.image-info.hide
%p
.image-info.hide
%span
.meta-filesize
=
number_to_human_size
(
old_blob
.
size
)
%span
.meta-filesize
=
number_to_human_size
(
old_blob
.
size
)
|
|
...
@@ -28,7 +28,7 @@
...
@@ -28,7 +28,7 @@
%span
.wrap
%span
.wrap
.frame.added
.frame.added
%a
{
href:
project_blob_path
(
@project
,
tree_join
(
diff_file
.
content_sha
,
diff_file
.
new_path
))
}
%a
{
href:
project_blob_path
(
@project
,
tree_join
(
diff_file
.
content_sha
,
diff_file
.
new_path
))
}
%img
.lazy
{
'data-src'
:
blob_raw_path
,
alt:
diff_file
.
new_path
}
=
image_tag
(
blob_raw_path
,
alt:
diff_file
.
new_path
)
%p
.image-info.hide
%p
.image-info.hide
%span
.meta-filesize
=
number_to_human_size
(
blob
.
size
)
%span
.meta-filesize
=
number_to_human_size
(
blob
.
size
)
|
|
...
@@ -41,10 +41,10 @@
...
@@ -41,10 +41,10 @@
.swipe.view.hide
.swipe.view.hide
.swipe-frame
.swipe-frame
.frame.deleted
.frame.deleted
%img
.lazy
{
'data-src'
:
old_blob_raw_path
,
alt:
diff_file
.
old_path
}
=
image_tag
(
old_blob_raw_path
,
alt:
diff_file
.
old_path
)
.swipe-wrap
.swipe-wrap
.frame.added
.frame.added
%img
.lazy
{
'data-src'
:
blob_raw_path
,
alt:
diff_file
.
new_path
}
=
image_tag
(
blob_raw_path
,
alt:
diff_file
.
new_path
)
%span
.swipe-bar
%span
.swipe-bar
%span
.top-handle
%span
.top-handle
%span
.bottom-handle
%span
.bottom-handle
...
@@ -52,9 +52,9 @@
...
@@ -52,9 +52,9 @@
.onion-skin.view.hide
.onion-skin.view.hide
.onion-skin-frame
.onion-skin-frame
.frame.deleted
.frame.deleted
%img
.lazy
{
'data-src'
:
old_blob_raw_path
,
alt:
diff_file
.
old_path
}
=
image_tag
(
old_blob_raw_path
,
alt:
diff_file
.
old_path
)
.frame.added
.frame.added
%img
.lazy
{
'data-src'
:
blob_raw_path
,
alt:
diff_file
.
new_path
}
=
image_tag
(
blob_raw_path
,
alt:
diff_file
.
new_path
)
.controls
.controls
.transparent
.transparent
.drag-track
.drag-track
...
...
doc/development/fe_guide/performance.md
View file @
710d0435
...
@@ -29,11 +29,12 @@ To improve the time to first render we are using lazy loading for images. This w
...
@@ -29,11 +29,12 @@ To improve the time to first render we are using lazy loading for images. This w
the actual image source on the
`data-src`
attribute. After the HTML is rendered and JavaScript is loaded,
the actual image source on the
`data-src`
attribute. After the HTML is rendered and JavaScript is loaded,
the value of
`data-src`
will be moved to
`src`
automatically if the image is in the current viewport.
the value of
`data-src`
will be moved to
`src`
automatically if the image is in the current viewport.
*
Prepare images in HTML for lazy loading by renaming the
`src`
attribute to
`data-src`
*
Prepare images in HTML for lazy loading by renaming the
`src`
attribute to
`data-src`
AND adding the class
`lazy`
*
If you are using the Rails
`image_tag`
helper, all images will be lazy-loaded by default unless
`lazy: false`
is provided.
*
If you are using the Rails
`image_tag`
helper, all images will be lazy-loaded by default unless
`lazy: false`
is provided.
If you are asynchronously adding content which contains lazy images then you need to call the function
If you are asynchronously adding content which contains lazy images then you need to call the function
`gl.lazyLoader.searchLazyImages()`
which will search for lazy images and load them if needed.
`gl.lazyLoader.searchLazyImages()`
which will search for lazy images and load them if needed.
But in general it should be handled automatically through a
`MutationObserver`
in the lazy loading function.
## Reducing Asset Footprint
## Reducing Asset Footprint
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment