Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
72121e71
Commit
72121e71
authored
Feb 15, 2021
by
Tom Quirk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address frontend maintainer feedback
parent
4296c365
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
8 deletions
+6
-8
app/assets/javascripts/issuable_list/components/issuable_item.vue
...ts/javascripts/issuable_list/components/issuable_item.vue
+6
-8
No files found.
app/assets/javascripts/issuable_list/components/issuable_item.vue
View file @
72121e71
...
...
@@ -4,6 +4,7 @@ import { GlLink, GlIcon, GlLabel, GlFormCheckbox, GlTooltipDirective } from '@gi
import
{
getIdFromGraphQLId
}
from
'
~/graphql_shared/utils
'
;
import
{
isScopedLabel
}
from
'
~/lib/utils/common_utils
'
;
import
{
getTimeago
}
from
'
~/lib/utils/datetime_utility
'
;
import
{
isExternal
,
setUrlFragment
}
from
'
~/lib/utils/url_utility
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
IssuableAssignees
from
'
~/vue_shared/components/issue/issue_assignees.vue
'
;
import
timeagoMixin
from
'
~/vue_shared/mixins/timeago
'
;
...
...
@@ -54,13 +55,7 @@ export default {
return
getIdFromGraphQLId
(
`
${
this
.
author
.
id
}
`
);
},
isIssuableUrlExternal
()
{
// Check if URL is relative, which means it is internal.
if
(
!
/^https
?
:
\/\/
/g
.
test
(
this
.
webUrl
))
{
return
false
;
}
// In case URL is absolute, it may or may not be internal,
// hence use `gon.gitlab_url` which is current instance domain.
return
!
this
.
webUrl
.
includes
(
gon
.
gitlab_url
);
return
isExternal
(
this
.
webUrl
);
},
labels
()
{
return
this
.
issuable
.
labels
?.
nodes
||
this
.
issuable
.
labels
||
[];
...
...
@@ -94,6 +89,9 @@ export default {
this
.
hasSlotContents
(
'
status
'
)
||
this
.
showDiscussions
||
this
.
issuable
.
assignees
,
);
},
issuableNotesLink
()
{
return
setUrlFragment
(
this
.
webUrl
,
'
notes
'
);
},
},
methods
:
{
hasSlotContents
(
slotName
)
{
...
...
@@ -209,7 +207,7 @@ export default {
<gl-link
v-gl-tooltip:tooltipcontainer
.
top
:title=
"__('Comments')"
:href=
"
`$
{webUrl}#notes`
"
:href=
"
issuableNotesLink
"
:class=
"
{ 'no-comments': !issuable.userDiscussionsCount }"
class="gl-reset-color!"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment