Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
727818b1
Commit
727818b1
authored
Dec 19, 2016
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
update runner limits spec to use group membership
parent
5b97b793
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
9 deletions
+9
-9
spec/factories/groups.rb
spec/factories/groups.rb
+1
-1
spec/features/ci_shared_runner_limits_spec.rb
spec/features/ci_shared_runner_limits_spec.rb
+8
-8
No files found.
spec/factories/groups.rb
View file @
727818b1
FactoryGirl
.
define
do
factory
:group
do
factory
:group
,
class:
Group
,
parent: :namespace
do
sequence
(
:name
)
{
|
n
|
"group
#{
n
}
"
}
path
{
name
.
downcase
.
gsub
(
/\s/
,
'_'
)
}
type
'Group'
...
...
spec/features/ci_shared_runner_limits_spec.rb
View file @
727818b1
...
...
@@ -2,8 +2,8 @@ require 'spec_helper'
feature
'CI shared runner limits'
,
feature:
true
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
,
:public
,
namespace:
namespace
,
shared_runners_enabled:
true
)
}
let
(
:
namespace
)
{
create
(
:namespace
)
}
let
!
(
:project
)
{
create
(
:project
,
:public
,
namespace:
group
,
shared_runners_enabled:
true
)
}
let
(
:
group
)
{
create
(
:group
)
}
before
do
login_as
(
user
)
...
...
@@ -11,7 +11,7 @@ feature 'CI shared runner limits', feature: true do
context
'when project member'
do
before
do
project
.
team
<<
[
user
,
:developer
]
group
.
add_developer
(
user
)
end
context
'without limit'
do
...
...
@@ -23,16 +23,16 @@ feature 'CI shared runner limits', feature: true do
context
'when limit is defined'
do
context
'when limit is exceeded'
do
let
(
:
namespace
)
{
create
(
:namespace
,
:with_used_build_minutes_limit
)
}
let
(
:
group
)
{
create
(
:group
,
:with_used_build_minutes_limit
)
}
scenario
'it displays a warning message on project homepage'
do
visit
namespace_project_path
(
project
.
namespace
,
project
)
expect_quota_exceeded_alert
(
"
#{
namespace
.
name
}
has exceeded their build minutes quota."
)
expect_quota_exceeded_alert
(
"
#{
group
.
name
}
has exceeded their build minutes quota."
)
end
end
context
'when limit not yet exceeded'
do
let
(
:
namespace
)
{
create
(
:namespace
,
:with_not_used_build_minutes_limit
)
}
let
(
:
group
)
{
create
(
:group
,
:with_not_used_build_minutes_limit
)
}
scenario
'it does not display a warning message on project homepage'
do
visit
namespace_project_path
(
project
.
namespace
,
project
)
...
...
@@ -41,7 +41,7 @@ feature 'CI shared runner limits', feature: true do
end
context
'when minutes are not yet set'
do
let
(
:
namespace
)
{
create
(
:namespace
,
:with_build_minutes_limit
)
}
let
(
:
group
)
{
create
(
:group
,
:with_build_minutes_limit
)
}
scenario
'it does not display a warning message on project homepage'
do
visit
namespace_project_path
(
project
.
namespace
,
project
)
...
...
@@ -52,7 +52,7 @@ feature 'CI shared runner limits', feature: true do
end
context
'when not a project member'
do
let
(
:
namespace
)
{
create
(
:namespace
,
:with_used_build_minutes_limit
)
}
let
(
:
group
)
{
create
(
:group
,
:with_used_build_minutes_limit
)
}
context
'when limit is defined and limit is exceeded'
do
scenario
'it does not display a warning message on project homepage'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment