Commit 7370f60f authored by Alex Kalderimis's avatar Alex Kalderimis

Review: Apply suggested changes

parent 4e501c94
...@@ -83,6 +83,7 @@ RSpec.describe Resolvers::BoardGroupings::EpicsResolver do ...@@ -83,6 +83,7 @@ RSpec.describe Resolvers::BoardGroupings::EpicsResolver do
it 'accepts negated issue params' do it 'accepts negated issue params' do
filters = { label_name: ['foo'], not: { label_name: %w(foo bar) } } filters = { label_name: ['foo'], not: { label_name: %w(foo bar) } }
expect(Boards::Issues::ListService).to receive(:new).with( expect(Boards::Issues::ListService).to receive(:new).with(
group_board.resource_parent, group_board.resource_parent,
current_user, current_user,
......
...@@ -48,21 +48,20 @@ RSpec.describe 'query terraform states' do ...@@ -48,21 +48,20 @@ RSpec.describe 'query terraform states' do
let(:current_user) { project.creator } let(:current_user) { project.creator }
let(:data) { graphql_data.dig('project', 'terraformStates') } let(:data) { graphql_data.dig('project', 'terraformStates') }
let(:download_path) do
expose_path( before do
post_graphql(query, current_user: current_user)
end
it 'returns terraform state data' do
download_path = expose_path(
api_v4_projects_terraform_state_versions_path( api_v4_projects_terraform_state_versions_path(
id: project.id, id: project.id,
name: terraform_state.name, name: terraform_state.name,
serial: latest_version.version serial: latest_version.version
) )
) )
end
before do
post_graphql(query, current_user: current_user)
end
it 'returns terraform state data' do
expect(data['nodes']).to contain_exactly({ expect(data['nodes']).to contain_exactly({
'id' => global_id_of(terraform_state), 'id' => global_id_of(terraform_state),
'name' => terraform_state.name, 'name' => terraform_state.name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment