Commit 7459f48a authored by Jarka Kadlecova's avatar Jarka Kadlecova

Fix specs, add issue number to TODOs comments

parent f8450992
...@@ -68,7 +68,7 @@ class Groups::EpicsController < Groups::ApplicationController ...@@ -68,7 +68,7 @@ class Groups::EpicsController < Groups::ApplicationController
end end
# we need to override the default state which is opened for now because we don't have # we need to override the default state which is opened for now because we don't have
# states for epics and need all as default for navigation to work correctly # states for epics and need all as default for navigation to work correctly (#4017)
def set_default_state def set_default_state
params[:state] = 'all' params[:state] = 'all'
end end
......
...@@ -4,7 +4,8 @@ class EpicsFinder < IssuableFinder ...@@ -4,7 +4,8 @@ class EpicsFinder < IssuableFinder
end end
def execute def execute
raise ArgumentError, 'group_id argument is missing' unless group raise ArgumentError, 'group_id argument is missing' unless params[:group_id]
return [] unless group
items = init_collection items = init_collection
items = by_created_at(items) items = by_created_at(items)
...@@ -19,7 +20,7 @@ class EpicsFinder < IssuableFinder ...@@ -19,7 +20,7 @@ class EpicsFinder < IssuableFinder
execute.count execute.count
end end
# we don't have states for epics for now this method # we don't have states for epics for now this method (#4017)
def count_by_state def count_by_state
{ {
all: row_count all: row_count
......
...@@ -31,6 +31,8 @@ module EE ...@@ -31,6 +31,8 @@ module EE
end end
rule { auditor }.enable :read_group rule { auditor }.enable :read_group
rule { admin }.enable :read_epic
rule { has_projects }.enable :read_epic
rule { admin | (can_owners_manage_ldap & owner) }.enable :admin_ldap_group_links rule { admin | (can_owners_manage_ldap & owner) }.enable :admin_ldap_group_links
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment