Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
75130477
Commit
75130477
authored
Sep 30, 2020
by
lauraMon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable ci_jobs_finder_refactor feature flag
parent
e48c9366
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
app/finders/ci/jobs_finder.rb
app/finders/ci/jobs_finder.rb
+2
-2
config/feature_flags/development/ci_jobs_finder_refactor.yml
config/feature_flags/development/ci_jobs_finder_refactor.yml
+1
-1
lib/api/ci/pipelines.rb
lib/api/ci/pipelines.rb
+2
-2
No files found.
app/finders/ci/jobs_finder.rb
View file @
75130477
...
...
@@ -25,7 +25,7 @@ module Ci
attr_reader
:current_user
,
:pipeline
,
:project
,
:params
,
:type
def
init_collection
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
)
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
,
default_enabled:
true
)
pipeline_jobs
||
project_jobs
||
all_jobs
else
project
?
project_builds
:
all_jobs
...
...
@@ -59,7 +59,7 @@ module Ci
end
def
filter_by_scope
(
builds
)
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
)
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
,
default_enabled:
true
)
return
filter_by_statuses!
(
params
[
:scope
],
builds
)
if
params
[
:scope
].
is_a?
(
Array
)
end
...
...
config/feature_flags/development/ci_jobs_finder_refactor.yml
View file @
75130477
...
...
@@ -4,4 +4,4 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36622
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/245183
group
:
group::continuous integration
type
:
development
default_enabled
:
fals
e
default_enabled
:
tru
e
lib/api/ci/pipelines.rb
View file @
75130477
...
...
@@ -128,7 +128,7 @@ module API
pipeline
=
user_project
.
all_pipelines
.
find
(
params
[
:pipeline_id
])
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
)
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
,
default_enabled:
true
)
builds
=
::
Ci
::
JobsFinder
.
new
(
current_user:
current_user
,
pipeline:
pipeline
,
params:
params
)
.
execute
...
...
@@ -157,7 +157,7 @@ module API
pipeline
=
user_project
.
all_pipelines
.
find
(
params
[
:pipeline_id
])
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
)
if
Feature
.
enabled?
(
:ci_jobs_finder_refactor
,
default_enabled:
true
)
bridges
=
::
Ci
::
JobsFinder
.
new
(
current_user:
current_user
,
pipeline:
pipeline
,
params:
params
,
type:
::
Ci
::
Bridge
)
.
execute
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment