Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
753b597a
Commit
753b597a
authored
Apr 04, 2022
by
jejacks0n
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove todos that are covered in an issue
parent
310de66b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
21 deletions
+2
-21
ee/spec/features/registrations/combined_registration_spec.rb
ee/spec/features/registrations/combined_registration_spec.rb
+2
-2
ee/spec/features/registrations/saas_user_registration_spec.rb
...pec/features/registrations/saas_user_registration_spec.rb
+0
-19
No files found.
ee/spec/features/registrations/combined_registration_spec.rb
View file @
753b597a
...
...
@@ -10,7 +10,7 @@ RSpec.describe 'Combined registration flow', :js do
before
do
# https://gitlab.com/gitlab-org/gitlab/-/issues/340302
stub_const
(
'Gitlab::QueryLimiting::Transaction::THRESHOLD'
,
270
)
stub_
experiments
(
experiment
s
)
stub_
feature_flags
(
feature_flag
s
)
allow
(
Gitlab
).
to
receive
(
:com?
).
and_return
(
true
)
sign_in
(
user
)
visit
users_sign_up_welcome_path
...
...
@@ -27,7 +27,7 @@ RSpec.describe 'Combined registration flow', :js do
combined_registration:
true
,
about_your_company_registration_flow:
false
}
end
end
it
'A user can create a group and project'
do
page
.
within
'.js-group-path-display'
do
...
...
ee/spec/features/registrations/saas_user_registration_spec.rb
View file @
753b597a
...
...
@@ -40,21 +40,10 @@ RSpec.describe "User registration", :js, :saas do
headers:
{}
)
# TODO: should we setup and confirm the user via email to replicate a real flow?
sign_in
user
visit
users_sign_up_welcome_path
end
describe
"when invited"
do
# TODO: should this be tested better in relation to how it changes flows here?
it
"should be tested"
end
describe
"using the trial flow"
do
# TODO: do we want to test this as part of this effort, or is it a separate lift?
it
"should be tested"
end
describe
"using the standard flow"
do
it
"presents the initial welcome step"
do
expect
(
page
).
to
have_content
(
'Welcome to GitLab'
)
...
...
@@ -106,8 +95,6 @@ RSpec.describe "User registration", :js, :saas do
# We end up in the continuous onboarding flow here...
expect
(
page
).
to
have_content
'Get started with GitLab'
# TODO: do we need to test continuous onboarding better here?
# So have to verify the newly created project by navigating to our projects...
visit
projects_path
...
...
@@ -121,9 +108,6 @@ RSpec.describe "User registration", :js, :saas do
fill_in
'import_group_name'
,
with:
'Test Group'
click_on
'GitHub'
# TODO: can this be tested to completion? that seems hard -- what can we do here?
# TODO: does the user end up in the continuous onboarding flow here?!?
expect
(
page
).
to
have_content
<<~
MESSAGE
.
tr
(
"
\n
"
,
' '
)
To connect GitHub repositories, you first need to authorize
GitLab to access the list of your GitHub repositories.
...
...
@@ -190,7 +174,6 @@ RSpec.describe "User registration", :js, :saas do
).
and_return
(
success:
true
)
end
# TODO: can these inputs really all be blank?
click_on
'Continue'
end
...
...
@@ -215,14 +198,12 @@ RSpec.describe "User registration", :js, :saas do
click_on
'Create project'
# TODO: do we end up in continuous onboarding?
expect
(
page
).
to
have_content
'Get started with GitLab'
end
end
context
"without a trial"
do
before
do
# TODO: can these inputs really all be blank?
click_on
'Continue'
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment