Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
754fefb3
Commit
754fefb3
authored
Jan 18, 2021
by
charlie ablett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply 1 suggestion(s) to 1 file(s)
parent
f2ff813a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+1
-1
No files found.
doc/development/code_review.md
View file @
754fefb3
...
@@ -24,7 +24,7 @@ uncovered edge cases.
...
@@ -24,7 +24,7 @@ uncovered edge cases.
The default approach is to choose a reviewer from your group or team for the first review.
The default approach is to choose a reviewer from your group or team for the first review.
This is only a recommendation and the reviewer may be from a different team.
This is only a recommendation and the reviewer may be from a different team.
However, it is recommended to pick someone who is a
[
domain expert
](
#domain-experts
)
.
However, it is recommended to pick someone who is a
[
domain expert
](
#domain-experts
)
.
If your merge request touches more than one domain (for example, Dynamic Analysis and GraphQL), ask for reviews from
two experts
.
If your merge request touches more than one domain (for example, Dynamic Analysis and GraphQL), ask for reviews from
an expert from each domain
.
You can read more about the importance of involving reviewer(s) in the section on the responsibility of the author below.
You can read more about the importance of involving reviewer(s) in the section on the responsibility of the author below.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment