Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
75b9b1b9
Commit
75b9b1b9
authored
May 28, 2020
by
Fabio Pitino
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix use of unknown track_error method
The correct use is Gitlab::ErrorTracking.track_exception
parent
1b841f49
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
3 deletions
+10
-3
app/services/ci/stop_environments_service.rb
app/services/ci/stop_environments_service.rb
+1
-1
changelogs/unreleased/fix-invalid-error-tracking-method.yml
changelogs/unreleased/fix-invalid-error-tracking-method.yml
+5
-0
spec/services/ci/stop_environments_service_spec.rb
spec/services/ci/stop_environments_service_spec.rb
+4
-2
No files found.
app/services/ci/stop_environments_service.rb
View file @
75b9b1b9
...
...
@@ -28,7 +28,7 @@ module Ci
stop_actions
.
each
do
|
stop_action
|
stop_action
.
play
(
stop_action
.
user
)
rescue
=>
e
Gitlab
::
ErrorTracking
.
track_e
rror
(
e
,
deployable_id:
stop_action
.
id
)
Gitlab
::
ErrorTracking
.
track_e
xception
(
e
,
deployable_id:
stop_action
.
id
)
end
end
...
...
changelogs/unreleased/fix-invalid-error-tracking-method.yml
0 → 100644
View file @
75b9b1b9
---
title
:
Fix NoMethodError by using the correct method to report exceptions to Sentry
merge_request
:
33260
author
:
type
:
fixed
spec/services/ci/stop_environments_service_spec.rb
View file @
75b9b1b9
...
...
@@ -222,8 +222,10 @@ describe Ci::StopEnvironmentsService do
it
'tracks the exception'
do
expect
(
Gitlab
::
ErrorTracking
)
.
to
receive
(
:track_error
)
.
with
(
Gitlab
::
Access
::
AccessDeniedError
,
anything
).
twice
.
to
receive
(
:track_exception
)
.
with
(
Gitlab
::
Access
::
AccessDeniedError
,
anything
)
.
twice
.
and_call_original
subject
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment