Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7634deb0
Commit
7634deb0
authored
Apr 07, 2020
by
Andy Soiron
Committed by
Mayra Cabrera
Apr 07, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove api_activity_logging feature flag
parent
1f2de8dd
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
9 deletions
+6
-9
changelogs/unreleased/remove_api_activity_logging_feature_flag.yml
...s/unreleased/remove_api_activity_logging_feature_flag.yml
+5
-0
lib/api/api.rb
lib/api/api.rb
+1
-1
spec/requests/api/api_spec.rb
spec/requests/api/api_spec.rb
+0
-8
No files found.
changelogs/unreleased/remove_api_activity_logging_feature_flag.yml
0 → 100644
View file @
7634deb0
---
title
:
Enable last user activity logging on the REST API
merge_request
:
28755
author
:
type
:
added
lib/api/api.rb
View file @
7634deb0
...
...
@@ -105,7 +105,7 @@ module API
namespace
do
after
do
::
Users
::
ActivityService
.
new
(
@current_user
).
execute
if
Feature
.
enabled?
(
:api_activity_logging
)
::
Users
::
ActivityService
.
new
(
@current_user
).
execute
end
# Keep in alphabetical order
...
...
spec/requests/api/api_spec.rb
View file @
7634deb0
...
...
@@ -13,13 +13,5 @@ describe API::API do
it
'updates the users last_activity_on date'
do
expect
{
get
api
(
'/groups'
,
user
)
}.
to
change
{
user
.
reload
.
last_activity_on
}.
to
(
Date
.
today
)
end
context
'when the the api_activity_logging feature is disabled'
do
it
'does not touch last_activity_on'
do
stub_feature_flags
(
api_activity_logging:
false
)
expect
{
get
api
(
'/groups'
,
user
)
}.
not_to
change
{
user
.
reload
.
last_activity_on
}
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment