Merge branch 'fix-dast-deactivation' into 'master'

Fixes the deactivation  of DAST schedule above limit

See merge request gitlab-org/gitlab!70371

ee/app/models/dast/profile_schedule.rb

@@ -88,6 +88,8 @@ class Dast::ProfileSchedule < ApplicationRecord
   # The will_save_change_to_active? returns false when the new object is created
   # with the same value as the db defaults. That's why we need to this indirect to call validate_plan_limit_not_exceeded.
   def validate_plan_limit_not_exceeded_while_activating
+    return if active == false
+
     validate_plan_limit_not_exceeded
   end
 end

ee/spec/models/dast/profile_schedule_spec.rb

@@ -97,6 +97,13 @@ RSpec.describe Dast::ProfileSchedule, type: :model do
           expect { inactive_schedule.save! }.to raise_error(ActiveRecord::RecordInvalid).and not_change { described_class.count }
           expect(inactive_schedule.errors[:base]).to contain_exactly("Maximum number of #{inactive_schedule.class.limit_name.humanize(capitalize: false)} (1) exceeded")
         end
+
+        it 'allows the schedule to be deactivated', :aggregate_failures do
+          active_schedule = subject.dup
+
+          expect { active_schedule.save! }.to change { described_class.count }
+          expect(active_schedule.update(active: false)).to be true
+        end
       end
     end
   end