Merge branch 'provide-have-aliases-for-completed-jobs' into 'master'

Provide has aliases for completed jobs/pipelines

See merge request gitlab-org/gitlab!28975

qa/qa/page/component/ci_badge_link.rb

@@ -13,6 +13,10 @@ module QA
             timeout ? completed?(timeout: timeout) : completed?
             status_badge == status
           end
+
+          # has_passed? => passed?
+          # has_failed? => failed?
+          alias_method :"has_#{status}?", :"#{status}?"
         end
 
         # e.g. def pending?; status_badge == 'pending'; end

qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb

@@ -32,7 +32,7 @@ module QA
           parent_pipeline.click_linked_job(project.name)
 
           expect(parent_pipeline).to have_job("child_job")
-          expect(parent_pipeline).to be_passed
+          expect(parent_pipeline).to have_passed
         end
       end
 
@@ -44,7 +44,7 @@ module QA
           parent_pipeline.click_linked_job(project.name)
 
           expect(parent_pipeline).to have_job("child_job")
-          expect(parent_pipeline).to be_failed
+          expect(parent_pipeline).to have_failed
         end
       end
 

qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb

@@ -32,7 +32,7 @@ module QA
           parent_pipeline.click_linked_job(project.name)
 
           expect(parent_pipeline).to have_job("child_job")
-          expect(parent_pipeline).to be_passed
+          expect(parent_pipeline).to have_passed
         end
       end
 
@@ -44,7 +44,7 @@ module QA
           parent_pipeline.click_linked_job(project.name)
 
           expect(parent_pipeline).to have_job("child_job")
-          expect(parent_pipeline).to be_passed
+          expect(parent_pipeline).to have_passed
         end
       end
 

qa/qa/specs/features/ee/browser_ui/6_release/multi-project_pipelines_spec.rb

@@ -85,7 +85,7 @@ module QA
         end
 
         Page::Project::Pipeline::Show.perform do |show|
-          expect(show).to be_passed
+          expect(show).to have_passed
           expect(show).to have_no_job("downstream_job")
 
           show.click_linked_job(downstream_project_name)