Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
76c555a0
Commit
76c555a0
authored
Sep 27, 2017
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
update emails service
parent
4b26ed8a
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
11 additions
and
11 deletions
+11
-11
app/controllers/admin/users_controller.rb
app/controllers/admin/users_controller.rb
+1
-1
app/controllers/profiles/emails_controller.rb
app/controllers/profiles/emails_controller.rb
+2
-2
app/models/user.rb
app/models/user.rb
+2
-2
app/services/emails/base_service.rb
app/services/emails/base_service.rb
+2
-2
lib/api/users.rb
lib/api/users.rb
+4
-4
No files found.
app/controllers/admin/users_controller.rb
View file @
76c555a0
...
...
@@ -155,7 +155,7 @@ class Admin::UsersController < Admin::ApplicationController
def
remove_email
email
=
user
.
emails
.
find
(
params
[
:email_id
])
success
=
Emails
::
DestroyService
.
new
(
current_user
,
user
,
email:
email
.
email
).
execute
success
=
Emails
::
DestroyService
.
new
(
current_user
,
user
:
user
,
email:
email
.
email
).
execute
respond_to
do
|
format
|
if
success
...
...
app/controllers/profiles/emails_controller.rb
View file @
76c555a0
...
...
@@ -5,7 +5,7 @@ class Profiles::EmailsController < Profiles::ApplicationController
end
def
create
@email
=
Emails
::
CreateService
.
new
(
current_user
,
current_user
,
email_params
).
execute
@email
=
Emails
::
CreateService
.
new
(
current_user
,
email_params
.
merge
(
user:
current_user
)
).
execute
if
@email
.
errors
.
blank?
NotificationService
.
new
.
new_email
(
@email
)
...
...
@@ -19,7 +19,7 @@ class Profiles::EmailsController < Profiles::ApplicationController
def
destroy
@email
=
current_user
.
emails
.
find
(
params
[
:id
])
Emails
::
DestroyService
.
new
(
current_user
,
current_user
,
email:
@email
.
email
).
execute
Emails
::
DestroyService
.
new
(
current_user
,
user:
current_user
,
email:
@email
.
email
).
execute
respond_to
do
|
format
|
format
.
html
{
redirect_to
profile_emails_url
,
status:
302
}
...
...
app/models/user.rb
View file @
76c555a0
...
...
@@ -545,8 +545,8 @@ class User < ActiveRecord::Base
def
update_emails_with_primary_email
primary_email_record
=
emails
.
find_by
(
email:
email
)
if
primary_email_record
Emails
::
DestroyService
.
new
(
self
,
self
,
email:
email
).
execute
Emails
::
CreateService
.
new
(
self
,
self
,
email:
email_was
).
execute
Emails
::
DestroyService
.
new
(
self
,
user:
self
,
email:
email
).
execute
Emails
::
CreateService
.
new
(
self
,
user:
self
,
email:
email_was
).
execute
end
end
...
...
app/services/emails/base_service.rb
View file @
76c555a0
module
Emails
class
BaseService
def
initialize
(
current_user
,
user
,
opts
)
def
initialize
(
current_user
,
opts
)
@current_user
=
current_user
@user
=
user
@user
=
opts
.
delete
(
:user
)
@email
=
opts
[
:email
]
end
end
...
...
lib/api/users.rb
View file @
76c555a0
...
...
@@ -332,7 +332,7 @@ module API
user
=
User
.
find_by
(
id:
params
.
delete
(
:id
))
not_found!
(
'User'
)
unless
user
email
=
Emails
::
CreateService
.
new
(
current_user
,
user
,
declared_params
(
include_missing:
false
)).
execute
email
=
Emails
::
CreateService
.
new
(
current_user
,
declared_params
(
include_missing:
false
).
merge
(
user:
user
)).
execute
if
email
.
errors
.
blank?
NotificationService
.
new
.
new_email
(
email
)
...
...
@@ -373,7 +373,7 @@ module API
not_found!
(
'Email'
)
unless
email
destroy_conditionally!
(
email
)
do
|
email
|
Emails
::
DestroyService
.
new
(
current_user
,
user
,
email:
email
.
email
).
execute
Emails
::
DestroyService
.
new
(
current_user
,
user
:
user
,
email:
email
.
email
).
execute
end
user
.
update_secondary_emails!
...
...
@@ -678,7 +678,7 @@ module API
requires
:email
,
type:
String
,
desc:
'The new email'
end
post
"emails"
do
email
=
Emails
::
CreateService
.
new
(
current_user
,
current_user
,
declared_params
).
execute
email
=
Emails
::
CreateService
.
new
(
current_user
,
declared_params
.
merge
(
user:
current_user
)
).
execute
if
email
.
errors
.
blank?
NotificationService
.
new
.
new_email
(
email
)
...
...
@@ -697,7 +697,7 @@ module API
not_found!
(
'Email'
)
unless
email
destroy_conditionally!
(
email
)
do
|
email
|
Emails
::
DestroyService
.
new
(
current_user
,
current_user
,
email:
email
.
email
).
execute
Emails
::
DestroyService
.
new
(
current_user
,
user:
current_user
,
email:
email
.
email
).
execute
end
current_user
.
update_secondary_emails!
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment