Merge branch '217987-make-all-of-the-project-selector-vue-component-s-props-required' into 'master'

Make all of the project selector vue component's props required

See merge request gitlab-org/gitlab!33746

app/assets/javascripts/vue_shared/components/project_selector/project_selector.vue

@@ -24,28 +24,23 @@ export default {
     },
     showNoResultsMessage: {
       type: Boolean,
-      required: false,
-      default: false,
+      required: true,
     },
     showMinimumSearchQueryMessage: {
       type: Boolean,
-      required: false,
-      default: false,
+      required: true,
     },
     showLoadingIndicator: {
       type: Boolean,
-      required: false,
-      default: false,
+      required: true,
     },
     showSearchErrorMessage: {
       type: Boolean,
-      required: false,
-      default: false,
+      required: true,
     },
     totalResults: {
       type: Number,
-      required: false,
-      default: 0,
+      required: true,
     },
   },
   data() {

ee/spec/frontend/security_dashboard/components/project_manager_spec.js

 import Vuex from 'vuex';
 import { shallowMount, createLocalVue } from '@vue/test-utils';
+import { merge } from 'lodash';
 
 import createDefaultState from 'ee/security_dashboard/store/modules/project_selector/state';
 
@@ -42,8 +43,7 @@ describe('Project Manager component', () => {
             isUpdatingProjects: jest.fn().mockReturnValue(isUpdatingProjects),
           },
           state: {
-            ...createDefaultState(),
-            ...state,
+            ...merge(createDefaultState(), state),
           },
         },
       },
@@ -155,11 +155,11 @@ describe('Project Manager component', () => {
     });
 
     it('passes the list of projects to the project-list component', () => {
-      const projects = [{}];
+      const projects = [{ foo: true }];
 
       factory({ state: { projects } });
 
-      expect(getProjectList().props('projects')).toBe(projects);
+      expect(getProjectList().props('projects')).toEqual(projects);
     });
 
     it.each([false, true])(

spec/frontend/vue_shared/components/project_selector/project_selector_spec.js

@@ -29,6 +29,7 @@ describe('ProjectSelector component', () => {
         showMinimumSearchQueryMessage: false,
         showLoadingIndicator: false,
         showSearchErrorMessage: false,
+        totalResults: searchResults.length,
       },
       attachToDocument: true,
     });