Commit 779ed1cc authored by Rémy Coutable's avatar Rémy Coutable

Fix spec/migrations/update_upload_paths_to_system_spec.rb to use the :migration metadata

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent 2af0b083
require "spec_helper" require 'spec_helper'
require Rails.root.join("db", "post_migrate", "20170317162059_update_upload_paths_to_system.rb") require Rails.root.join('db', 'post_migrate', '20170317162059_update_upload_paths_to_system.rb')
describe UpdateUploadPathsToSystem do describe UpdateUploadPathsToSystem, :migration do
let(:migration) { described_class.new } let(:migration) { described_class.new }
let(:uploads_table) { table(:uploads) }
let(:base_upload_attributes) { { size: 42, uploader: 'John Doe' } }
before do before do
allow(migration).to receive(:say) allow(migration).to receive(:say)
end end
describe "#uploads_to_switch_to_new_path" do describe '#uploads_to_switch_to_new_path' do
it "contains only uploads with the old path for the correct models" do it 'contains only uploads with the old path for the correct models' do
_upload_for_other_type = create(:upload, model: create(:ci_pipeline), path: "uploads/ci_pipeline/avatar.jpg") _upload_for_other_type = create_upload('Pipeline', 'uploads/ci_pipeline/avatar.jpg')
_upload_with_system_path = create(:upload, model: create(:project), path: "uploads/-/system/project/avatar.jpg") _upload_with_system_path = create_upload('Project', 'uploads/-/system/project/avatar.jpg')
_upload_with_other_path = create(:upload, model: create(:project), path: "thelongsecretforafileupload/avatar.jpg") _upload_with_other_path = create_upload('Project', 'thelongsecretforafileupload/avatar.jpg')
old_upload = create(:upload, model: create(:project), path: "uploads/project/avatar.jpg") old_upload = create_upload('Project', 'uploads/project/avatar.jpg')
group_upload = create(:upload, model: create(:group), path: "uploads/group/avatar.jpg") group_upload = create_upload('Namespace', 'uploads/group/avatar.jpg')
expect(Upload.where(migration.uploads_to_switch_to_new_path)).to contain_exactly(old_upload, group_upload) expect(uploads_table.where(migration.uploads_to_switch_to_new_path)).to contain_exactly(old_upload, group_upload)
end end
end end
describe "#uploads_to_switch_to_old_path" do describe '#uploads_to_switch_to_old_path' do
it "contains only uploads with the new path for the correct models" do it 'contains only uploads with the new path for the correct models' do
_upload_for_other_type = create(:upload, model: create(:ci_pipeline), path: "uploads/ci_pipeline/avatar.jpg") _upload_for_other_type = create_upload('Pipeline', 'uploads/ci_pipeline/avatar.jpg')
upload_with_system_path = create(:upload, model: create(:project), path: "uploads/-/system/project/avatar.jpg") upload_with_system_path = create_upload('Project', 'uploads/-/system/project/avatar.jpg')
_upload_with_other_path = create(:upload, model: create(:project), path: "thelongsecretforafileupload/avatar.jpg") _upload_with_other_path = create_upload('Project', 'thelongsecretforafileupload/avatar.jpg')
_old_upload = create(:upload, model: create(:project), path: "uploads/project/avatar.jpg") _old_upload = create_upload('Project', 'uploads/project/avatar.jpg')
expect(Upload.where(migration.uploads_to_switch_to_old_path)).to contain_exactly(upload_with_system_path) expect(uploads_table.where(migration.uploads_to_switch_to_old_path)).to contain_exactly(upload_with_system_path)
end end
end end
describe "#up", :truncate do describe '#up' do
it "updates old upload records to the new path" do it 'updates old upload records to the new path' do
old_upload = create(:upload, model: create(:project), path: "uploads/project/avatar.jpg") old_upload = create_upload('Project', 'uploads/project/avatar.jpg')
migration.up migration.up
expect(old_upload.reload.path).to eq("uploads/-/system/project/avatar.jpg") expect(old_upload.reload.path).to eq('uploads/-/system/project/avatar.jpg')
end end
end end
describe "#down", :truncate do describe '#down' do
it "updates the new system patsh to the old paths" do it 'updates the new system patsh to the old paths' do
new_upload = create(:upload, model: create(:project), path: "uploads/-/system/project/avatar.jpg") new_upload = create_upload('Project', 'uploads/-/system/project/avatar.jpg')
migration.down migration.down
expect(new_upload.reload.path).to eq("uploads/project/avatar.jpg") expect(new_upload.reload.path).to eq('uploads/project/avatar.jpg')
end end
end end
def create_upload(type, path)
uploads_table.create(base_upload_attributes.merge(model_type: type, path: path))
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment