Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
78031069
Commit
78031069
authored
Mar 11, 2022
by
Dave Pisek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Review feedback: add project as prop to click-track
parent
9162fd34
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
1 deletion
+7
-1
ee/app/assets/javascripts/security_dashboard/components/shared/security_training_promo.vue
...y_dashboard/components/shared/security_training_promo.vue
+2
-1
ee/app/assets/javascripts/security_dashboard/security_dashboard_init.js
...javascripts/security_dashboard/security_dashboard_init.js
+1
-0
ee/spec/frontend/security_dashboard/components/project/project_security_dashboard_spec.js
...ard/components/project/project_security_dashboard_spec.js
+1
-0
ee/spec/frontend/security_dashboard/components/shared/security_training_promo_spec.js
...shboard/components/shared/security_training_promo_spec.js
+3
-0
No files found.
ee/app/assets/javascripts/security_dashboard/components/shared/security_training_promo.vue
View file @
78031069
...
...
@@ -14,7 +14,7 @@ export default {
UserCalloutDismisser
,
},
mixins
:
[
Tracking
.
mixin
()],
inject
:
[
'
securityConfigurationPath
'
],
inject
:
[
'
securityConfigurationPath
'
,
'
projectFullPath
'
],
i18n
:
{
title
:
__
(
'
Reduce risk and triage fewer vulnerabilities with security training
'
),
buttonText
:
__
(
'
Enable security training
'
),
...
...
@@ -31,6 +31,7 @@ export default {
trackCTAClick
()
{
this
.
track
(
TRACK_PROMOTION_BANNER_CTA_CLICK_ACTION
,
{
label
:
TRACK_PROMOTION_BANNER_CTA_CLICK_LABEL
,
property
:
this
.
projectFullPath
,
});
},
},
...
...
ee/app/assets/javascripts/security_dashboard/security_dashboard_init.js
View file @
78031069
...
...
@@ -33,6 +33,7 @@ export default (el, dashboardType) => {
dashboardDocumentation
:
el
.
dataset
.
dashboardDocumentation
,
emptyStateSvgPath
:
el
.
dataset
.
emptyStateSvgPath
,
groupFullPath
:
el
.
dataset
.
groupFullPath
,
projectFullPath
:
el
.
dataset
.
projectFullPath
,
securityConfigurationPath
:
el
.
dataset
.
securityConfigurationPath
,
surveyRequestSvgPath
:
el
.
dataset
.
surveyRequestSvgPath
,
securityDashboardHelpPath
:
el
.
dataset
.
securityDashboardHelpPath
,
...
...
ee/spec/frontend/security_dashboard/components/project/project_security_dashboard_spec.js
View file @
78031069
...
...
@@ -55,6 +55,7 @@ describe('Project Security Dashboard component', () => {
provide
:
{
// To be consumed by SecurityDashboardLayout
sbomSurveySvgPath
:
'
/
'
,
projectFullPath
:
'
namespace/project
'
,
glFeatures
:
{
secureVulnerabilityTraining
:
secureVulnerabilityTrainingEnabled
,
},
...
...
ee/spec/frontend/security_dashboard/components/shared/security_training_promo_spec.js
View file @
78031069
...
...
@@ -10,6 +10,7 @@ import {
const
SECURITY_CONFIGURATION_PATH
=
'
foo/bar
'
;
const
VULNERABILITY_MANAGEMENT_TAB_NAME
=
'
vulnerability-management
'
;
const
PROJECT_FULL_PATH
=
'
namespace/project
'
;
describe
(
'
Security training promo component
'
,
()
=>
{
let
wrapper
;
...
...
@@ -18,6 +19,7 @@ describe('Security training promo component', () => {
const
createWrapper
=
({
shouldShowCallout
=
true
}
=
{})
=>
shallowMount
(
SecurityTrainingPromo
,
{
provide
:
{
projectFullPath
:
PROJECT_FULL_PATH
,
securityConfigurationPath
:
SECURITY_CONFIGURATION_PATH
,
},
stubs
:
{
...
...
@@ -94,6 +96,7 @@ describe('Security training promo component', () => {
expect
(
trackingSpy
).
toHaveBeenCalledWith
(
undefined
,
TRACK_PROMOTION_BANNER_CTA_CLICK_ACTION
,
{
label
:
TRACK_PROMOTION_BANNER_CTA_CLICK_LABEL
,
property
:
PROJECT_FULL_PATH
,
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment