Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7827b4d0
Commit
7827b4d0
authored
Feb 10, 2021
by
Alishan Ladhani
Committed by
Peter Leitzen
Feb 15, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Require Product Intelligence reviews for backend Snowplow events
parent
c7f3be18
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
3 deletions
+7
-3
danger/product_intelligence/Dangerfile
danger/product_intelligence/Dangerfile
+7
-3
No files found.
danger/product_intelligence/Dangerfile
View file @
7827b4d0
...
...
@@ -45,9 +45,13 @@ usage_data_changed_files = all_changed_files.grep(%r{(usage_data)})
metrics_changed_files
=
all_changed_files
.
grep
(
%r{((ee/)?config/metrics/.*
\.
yml)}
)
dictionary_changed_file
=
all_changed_files
.
grep
(
%r{(doc/development/usage_ping/dictionary.md)}
)
usage_changed_files
=
usage_data_changed_files
+
tracking_changed_files
+
metrics_changed_files
+
dictionary_changed_file
snowplow_changed_files
=
all_changed_files
.
select
do
|
file
|
helper
.
changed_lines
(
file
).
grep
(
%r{Gitlab::Tracking
\.
event}
).
any?
end
matching_changed_files
=
usage_data_changed_files
+
tracking_changed_files
+
metrics_changed_files
+
dictionary_changed_file
+
snowplow_changed_files
if
usage
_changed_files
.
any?
if
matching
_changed_files
.
any?
mention
=
if
helper
.
draft_mr?
"`
#{
ENGINEERS_GROUP
}
`"
...
...
@@ -55,7 +59,7 @@ if usage_changed_files.any?
ENGINEERS_GROUP
end
warn
format
(
CHANGED_FILES_MESSAGE
,
changed_files:
helper
.
markdown_list
(
usage
_changed_files
),
engineers_group:
mention
)
warn
format
(
CHANGED_FILES_MESSAGE
,
changed_files:
helper
.
markdown_list
(
matching
_changed_files
),
engineers_group:
mention
)
warn
format
(
UPDATE_METRICS_DEFINITIONS_MESSAGE
)
if
usage_data_changed_files
.
any?
fail
format
(
UPDATE_DICTIONARY_MESSAGE
)
if
metrics_changed_files
.
any?
&&
dictionary_changed_file
.
empty?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment