Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlan-repository' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/repository

See merge request gitlab-org/gitlab!58308

.rubocop_manual_todo.yml

@@ -716,11 +716,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/prometheus/query_variables_spec.rb
     - spec/lib/gitlab/reactive_cache_set_cache_spec.rb
     - spec/lib/gitlab/reference_extractor_spec.rb
-    - spec/lib/gitlab/repository_cache_spec.rb
-    - spec/lib/gitlab/repository_hash_cache_spec.rb
-    - spec/lib/gitlab/repository_set_cache_spec.rb
-    - spec/lib/gitlab/repository_size_checker_spec.rb
-    - spec/lib/gitlab/repository_size_error_message_spec.rb
     - spec/lib/gitlab/search_results_spec.rb
     - spec/lib/gitlab/shell_spec.rb
     - spec/models/abuse_report_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlan-repository.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/repository
+merge_request: 58308
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/repository_cache_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::RepositoryCache do
   let_it_be(:project) { create(:project) }
+
   let(:backend) { double('backend').as_null_object }
   let(:repository) { project.repository }
   let(:namespace) { "#{repository.full_path}:#{project.id}" }
@@ -38,6 +39,7 @@ RSpec.describe Gitlab::RepositoryCache do
 
     describe 'personal snippet repository' do
       let_it_be(:personal_snippet) { create(:personal_snippet) }
+
       let(:namespace) { repository.full_path }
 
       it_behaves_like 'cache_key examples' do

spec/lib/gitlab/repository_hash_cache_spec.rb

@@ -4,6 +4,7 @@ require "spec_helper"
 
 RSpec.describe Gitlab::RepositoryHashCache, :clean_gitlab_redis_cache do
   let_it_be(:project) { create(:project) }
+
   let(:repository) { project.repository }
   let(:namespace) { "#{repository.full_path}:#{project.id}" }
   let(:cache) { described_class.new(repository) }

spec/lib/gitlab/repository_set_cache_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::RepositorySetCache, :clean_gitlab_redis_cache do
   let_it_be(:project) { create(:project) }
+
   let(:repository) { project.repository }
   let(:namespace) { "#{repository.full_path}:#{project.id}" }
   let(:cache) { described_class.new(repository) }
@@ -34,6 +35,7 @@ RSpec.describe Gitlab::RepositorySetCache, :clean_gitlab_redis_cache do
 
     describe 'personal snippet repository' do
       let_it_be(:personal_snippet) { create(:personal_snippet) }
+
       let(:namespace) { repository.full_path }
 
       it_behaves_like 'cache_key examples' do

spec/lib/gitlab/repository_size_checker_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::RepositorySizeChecker do
   let_it_be(:namespace) { nil }
+
   let(:current_size) { 0 }
   let(:limit) { 50 }
   let(:enabled) { true }

spec/lib/gitlab/repository_size_error_message_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::RepositorySizeErrorMessage do
   let_it_be(:namespace) { build(:namespace) }
+
   let(:checker) do
     Gitlab::RepositorySizeChecker.new(
       current_size_proc: -> { 15.megabytes },