Commit 78d654f9 authored by Pedro Pombeiro's avatar Pedro Pombeiro

Address MR review comments

parent 94c5034e
...@@ -16,29 +16,29 @@ module Mutations ...@@ -16,29 +16,29 @@ module Mutations
argument :description, GraphQL::STRING_TYPE, argument :description, GraphQL::STRING_TYPE,
required: false, required: false,
description: 'Description of the runner.' description: 'Description of the runner.'
argument :maximum_timeout, GraphQL::INT_TYPE, argument :maximum_timeout, GraphQL::INT_TYPE,
required: false, required: false,
description: 'Maximum timeout (in seconds) for jobs processed by the runner.' description: 'Maximum timeout (in seconds) for jobs processed by the runner.'
argument :access_level, ::Types::Ci::RunnerAccessLevelEnum, argument :access_level, ::Types::Ci::RunnerAccessLevelEnum,
required: false, required: false,
description: 'Access level of the runner.' description: 'Access level of the runner.'
argument :active, GraphQL::BOOLEAN_TYPE, argument :active, GraphQL::BOOLEAN_TYPE,
required: false, required: false,
description: 'Indicates the runner is allowed to receive jobs.' description: 'Indicates the runner is allowed to receive jobs.'
argument :locked, GraphQL::BOOLEAN_TYPE, required: false, argument :locked, GraphQL::BOOLEAN_TYPE, required: false,
description: 'Indicates the runner is locked.' description: 'Indicates the runner is locked.'
argument :run_untagged, GraphQL::BOOLEAN_TYPE, argument :run_untagged, GraphQL::BOOLEAN_TYPE,
required: false, required: false,
description: 'Indicates the runner is able to run untagged jobs.' description: 'Indicates the runner is able to run untagged jobs.'
argument :tag_list, [GraphQL::STRING_TYPE], required: false, argument :tag_list, [GraphQL::STRING_TYPE], required: false,
description: 'Tags associated with the runner.' description: 'Tags associated with the runner.'
field :runner, field :runner,
Types::Ci::RunnerType, Types::Ci::RunnerType,
......
...@@ -66,15 +66,7 @@ RSpec.describe Mutations::Ci::Runner::Update do ...@@ -66,15 +66,7 @@ RSpec.describe Mutations::Ci::Runner::Update do
context 'with valid arguments' do context 'with valid arguments' do
it 'updates runner with correct values' do it 'updates runner with correct values' do
expected_attributes = { expected_attributes = mutation_params.except(:id)
description: 'updated description',
maximum_timeout: 900,
access_level: 'ref_protected',
active: false,
locked: true,
run_untagged: false,
tag_list: %w(tag1 tag2)
}
subject subject
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment