Merge branch 'mo-remove-group-code-coverage-visit-ff' into 'master'

Remove usage_data_i_testing_group_code_coverage_visit_total feature flag

See merge request gitlab-org/gitlab!70950

config/feature_flags/development/usage_data_i_testing_group_code_coverage_visit_total.yml

----
-name: usage_data_i_testing_group_code_coverage_visit_total
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/51382
-rollout_issue_url:
-milestone: '13.8'
-type: development
-group: group::testing
-default_enabled: true

ee/app/assets/javascripts/analytics/repository_analytics/components/group_repository_analytics.vue

 <script>
 import Api from '~/api';
 import { s__ } from '~/locale';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 import DownloadTestCoverage from './download_test_coverage.vue';
 import TestCoverageSummary from './test_coverage_summary.vue';
 import TestCoverageTable from './test_coverage_table.vue';
 
-export const VISIT_EVENT_FEATURE_FLAG = 'usageDataITestingGroupCodeCoverageVisitTotal';
 export const VISIT_EVENT_NAME = 'i_testing_group_code_coverage_visit_total';
 
 export default {
@@ -16,11 +14,8 @@ export default {
     TestCoverageTable,
     DownloadTestCoverage,
   },
-  mixins: [glFeatureFlagsMixin()],
   mounted() {
-    if (this.glFeatures[VISIT_EVENT_FEATURE_FLAG]) {
-      Api.trackRedisHllUserEvent(VISIT_EVENT_NAME);
-    }
+    Api.trackRedisHllUserEvent(VISIT_EVENT_NAME);
   },
   text: {
     codeCoverageHeader: s__('RepositoriesAnalytics|Test Code Coverage'),

ee/app/controllers/groups/analytics/repository_analytics_controller.rb

@@ -5,9 +5,6 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl
 
   before_action :load_group
   before_action -> { authorize_view_by_action!(:read_group_repository_analytics) }
-  before_action only: [:show] do
-    push_frontend_feature_flag(:usage_data_i_testing_group_code_coverage_visit_total, @group, default_enabled: :yaml)
-  end
 
   def show
     Gitlab::Tracking.event(self.class.name, 'show', **pageview_tracker_params)

ee/spec/frontend/analytics/repository_analytics/components/group_repository_analytics_spec.js

@@ -46,15 +46,5 @@ describe('Group repository analytics app', () => {
         expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(VISIT_EVENT_NAME);
       });
     });
-
-    describe('with the feature flag disabled', () => {
-      beforeEach(() => {
-        createComponent({ [VISIT_EVENT_FEATURE_FLAG]: false });
-      });
-
-      it('does not track a visit event on mount', () => {
-        expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
-      });
-    });
   });
 });

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -158,7 +158,6 @@
   category: testing
   redis_slot: testing
   aggregation: weekly
-  feature_flag: usage_data_i_testing_group_code_coverage_visit_total
 - name: i_testing_full_code_quality_report_total
   category: testing
   redis_slot: testing