Don't cache has external wiki on secondaries nodes

parent 913093ce
...@@ -812,7 +812,7 @@ class Project < ActiveRecord::Base ...@@ -812,7 +812,7 @@ class Project < ActiveRecord::Base
end end
def cache_has_external_wiki def cache_has_external_wiki
update_column(:has_external_wiki, services.external_wikis.any?) update_column(:has_external_wiki, services.external_wikis.any?) unless Gitlab::Geo.secondary?
end end
def find_or_initialize_services def find_or_initialize_services
......
...@@ -738,6 +738,35 @@ describe Project, models: true do ...@@ -738,6 +738,35 @@ describe Project, models: true do
end.not_to change { project.has_external_issue_tracker } end.not_to change { project.has_external_issue_tracker }
end end
end end
describe '#cache_has_external_wiki' do
let(:project) { create(:empty_project, has_external_wiki: nil) }
it 'stores true if there is any external_wikis' do
services = double(:service, external_wikis: [ExternalWikiService.new])
expect(project).to receive(:services).and_return(services)
expect do
project.cache_has_external_wiki
end.to change { project.has_external_wiki}.to(true)
end
it 'stores false if there is no external_wikis' do
services = double(:service, external_wikis: [])
expect(project).to receive(:services).and_return(services)
expect do
project.cache_has_external_wiki
end.to change { project.has_external_wiki}.to(false)
end
it 'does not cache data when in a secondary gitlab geo node' do
allow(Gitlab::Geo).to receive(:secondary?) { true }
expect do
project.cache_has_external_wiki
end.not_to change { project.has_external_wiki }
end
end end
describe '#has_wiki?' do describe '#has_wiki?' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment