Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7d1890c8
Commit
7d1890c8
authored
Apr 12, 2021
by
Marius Bobin
Committed by
Dmytro Zaporozhets (DZ)
Apr 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove feature flag for async pipeline processing [RUN ALL RSPEC] [RUN AS-IF-FOSS]
parent
208d4aab
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
28 deletions
+6
-28
changelogs/unreleased/ci-remove-ff-for-pipeline-async-processing-326217.yml
...sed/ci-remove-ff-for-pipeline-async-processing-326217.yml
+5
-0
config/feature_flags/development/ci_async_initial_pipeline_processing.yml
...lags/development/ci_async_initial_pipeline_processing.yml
+0
-8
lib/gitlab/ci/pipeline/chain/pipeline/process.rb
lib/gitlab/ci/pipeline/chain/pipeline/process.rb
+1
-5
spec/lib/gitlab/ci/pipeline/chain/pipeline/process_spec.rb
spec/lib/gitlab/ci/pipeline/chain/pipeline/process_spec.rb
+0
-15
No files found.
changelogs/unreleased/ci-remove-ff-for-pipeline-async-processing-326217.yml
0 → 100644
View file @
7d1890c8
---
title
:
Move initial pipeline processing to Sidekiq
merge_request
:
58901
author
:
type
:
changed
config/feature_flags/development/ci_async_initial_pipeline_processing.yml
deleted
100644 → 0
View file @
208d4aab
---
name
:
ci_async_initial_pipeline_processing
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57589
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/326217
milestone
:
'
13.11'
type
:
development
group
:
group::continuous integration
default_enabled
:
false
lib/gitlab/ci/pipeline/chain/pipeline/process.rb
View file @
7d1890c8
...
@@ -8,11 +8,7 @@ module Gitlab
...
@@ -8,11 +8,7 @@ module Gitlab
# After pipeline has been successfully created we can start processing it.
# After pipeline has been successfully created we can start processing it.
class
Process
<
Chain
::
Base
class
Process
<
Chain
::
Base
def
perform!
def
perform!
if
::
Feature
.
enabled?
(
:ci_async_initial_pipeline_processing
,
project
,
default_enabled: :yaml
)
::
Ci
::
InitialPipelineProcessWorker
.
perform_async
(
pipeline
.
id
)
::
Ci
::
InitialPipelineProcessWorker
.
perform_async
(
pipeline
.
id
)
else
::
Ci
::
ProcessPipelineService
.
new
(
pipeline
).
execute
end
end
end
def
break?
def
break?
...
...
spec/lib/gitlab/ci/pipeline/chain/pipeline/process_spec.rb
View file @
7d1890c8
...
@@ -23,21 +23,6 @@ RSpec.describe Gitlab::Ci::Pipeline::Chain::Pipeline::Process do
...
@@ -23,21 +23,6 @@ RSpec.describe Gitlab::Ci::Pipeline::Chain::Pipeline::Process do
perform
perform
end
end
context
'with async processing disabled'
do
before
do
stub_feature_flags
(
ci_async_initial_pipeline_processing:
false
)
end
it
'processes pipeline inline'
do
expect
(
::
Ci
::
ProcessPipelineService
)
.
to
receive
(
:new
)
.
with
(
pipeline
)
.
and_call_original
perform
end
end
end
end
describe
'#break?'
do
describe
'#break?'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment