Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7de4c04b
Commit
7de4c04b
authored
Aug 11, 2020
by
Furkan Ayhan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable FF ci_variables_api_filter_environment_scope by default
parent
27b63550
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
8 deletions
+16
-8
changelogs/unreleased/enable-ci_variables_api_filter_environment_scope-by-default.yml
...-ci_variables_api_filter_environment_scope-by-default.yml
+5
-0
doc/api/project_level_variables.md
doc/api/project_level_variables.md
+10
-7
lib/gitlab/ci/features.rb
lib/gitlab/ci/features.rb
+1
-1
No files found.
changelogs/unreleased/enable-ci_variables_api_filter_environment_scope-by-default.yml
0 → 100644
View file @
7de4c04b
---
title
:
Enable FF ci_variables_api_filter_environment_scope by default
merge_request
:
39209
author
:
type
:
changed
doc/api/project_level_variables.md
View file @
7de4c04b
...
...
@@ -155,8 +155,10 @@ curl --request DELETE --header "PRIVATE-TOKEN: <your_access_token>" "https://git
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/34490) in GitLab 13.2.
> - It's deployed behind a feature flag, disabled by default.
> - It's disabled on GitLab.com.
> - To use it in GitLab self-managed instances, ask a GitLab administrator to enable it.
> - [Became enabled by default](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39209) on GitLab 13.3.
> - It's enabled on GitLab.com.
> - It's recommended for production use.
> - For GitLab self-managed instances, GitLab administrators can opt to [disable it](#enable-or-disable).
This parameter is used for filtering by attributes, such as
`environment_scope`
.
...
...
@@ -168,17 +170,18 @@ curl --request DELETE --header "PRIVATE-TOKEN: <your_access_token>" "https://git
### Enable or disable
It is deployed behind a feature flag that is
**enabled by default**
.
[
GitLab administrators with access to the GitLab Rails console
](
../administration/feature_flags.md
)
can
en
able it for your instance.
can
opt to dis
able it for your instance.
To
en
able it:
To
dis
able it:
```
ruby
Feature
.
en
able
(
:ci_variables_api_filter_environment_scope
)
Feature
.
dis
able
(
:ci_variables_api_filter_environment_scope
)
```
To
dis
able it:
To
en
able it:
```
ruby
Feature
.
dis
able
(
:ci_variables_api_filter_environment_scope
)
Feature
.
en
able
(
:ci_variables_api_filter_environment_scope
)
```
lib/gitlab/ci/features.rb
View file @
7de4c04b
...
...
@@ -41,7 +41,7 @@ module Gitlab
# Remove in https://gitlab.com/gitlab-org/gitlab/-/issues/227052
def
self
.
variables_api_filter_environment_scope?
::
Feature
.
enabled?
(
:ci_variables_api_filter_environment_scope
,
default_enabled:
fals
e
)
::
Feature
.
enabled?
(
:ci_variables_api_filter_environment_scope
,
default_enabled:
tru
e
)
end
# This FF is only used for development purpose to test that warnings can be
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment