Commit 801d158b authored by Simon Knox's avatar Simon Knox

Merge branch '284008-remove-the-breadcrumb-on-subgroup-top-page' into 'master'

Remove "Details" from breadcrumb and JSON+JD on Group top page

See merge request gitlab-org/gitlab!47854
parents f20d70eb 36239b5b
- breadcrumb_title _("Details")
- @content_class = "limit-container-width" unless fluid_layout - @content_class = "limit-container-width" unless fluid_layout
- page_itemtype 'https://schema.org/Organization' - page_itemtype 'https://schema.org/Organization'
- @skip_current_level_breadcrumb = true
- if show_thanks_for_purchase_banner? - if show_thanks_for_purchase_banner?
= render_if_exists 'shared/thanks_for_purchase_banner', plan_title: plan_title, quantity: params[:purchased_quantity].to_i = render_if_exists 'shared/thanks_for_purchase_banner', plan_title: plan_title, quantity: params[:purchased_quantity].to_i
......
---
title: Remove "Details" from breadcrumb and JSON+JD on Group top page
merge_request: 47854
author: Takuya Noguchi
type: changed
...@@ -44,15 +44,12 @@ RSpec.describe 'Breadcrumbs schema markup', :aggregate_failures do ...@@ -44,15 +44,12 @@ RSpec.describe 'Breadcrumbs schema markup', :aggregate_failures do
item_list = get_schema_content item_list = get_schema_content
expect(item_list.size).to eq 3 expect(item_list.size).to eq 2
expect(item_list[0]['name']).to eq group.name expect(item_list[0]['name']).to eq group.name
expect(item_list[0]['item']).to eq group_url(group) expect(item_list[0]['item']).to eq group_url(group)
expect(item_list[1]['name']).to eq subgroup.name expect(item_list[1]['name']).to eq subgroup.name
expect(item_list[1]['item']).to eq group_url(subgroup) expect(item_list[1]['item']).to eq group_url(subgroup)
expect(item_list[2]['name']).to eq 'Details'
expect(item_list[2]['item']).to eq group_url(subgroup)
end end
it 'generates the breadcrumb schema for issues' do it 'generates the breadcrumb schema for issues' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment