Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
805635c4
Commit
805635c4
authored
Nov 25, 2021
by
Igor Drozdov
Committed by
Mayra Cabrera
Nov 25, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove limited_diff_highlighting feature flag
parent
88343240
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
23 deletions
+0
-23
config/feature_flags/development/limited_diff_highlighting.yml
...g/feature_flags/development/limited_diff_highlighting.yml
+0
-8
lib/gitlab/diff/highlight.rb
lib/gitlab/diff/highlight.rb
+0
-1
spec/lib/gitlab/diff/highlight_spec.rb
spec/lib/gitlab/diff/highlight_spec.rb
+0
-14
No files found.
config/feature_flags/development/limited_diff_highlighting.yml
deleted
100644 → 0
View file @
88343240
---
name
:
limited_diff_highlighting
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53768
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/323566
milestone
:
'
13.12'
type
:
development
group
:
group::source code
default_enabled
:
true
lib/gitlab/diff/highlight.rb
View file @
805635c4
...
...
@@ -159,7 +159,6 @@ module Gitlab
end
def
blobs_too_large?
return
false
unless
Feature
.
enabled?
(
:limited_diff_highlighting
,
project
,
default_enabled: :yaml
)
return
true
if
Gitlab
::
Highlight
.
too_large?
(
diff_file
.
old_blob
&
.
size
)
Gitlab
::
Highlight
.
too_large?
(
diff_file
.
new_blob
&
.
size
)
...
...
spec/lib/gitlab/diff/highlight_spec.rb
View file @
805635c4
...
...
@@ -151,20 +151,6 @@ RSpec.describe Gitlab::Diff::Highlight do
expect
(
subject
[
2
].
rich_text
).
to
eq
(
%Q{ <span id="LC7" class="line" lang=""> def popen(cmd, path=nil)</span>
\n
}
)
expect
(
subject
[
2
].
rich_text
).
to
be_html_safe
end
context
'when limited_diff_highlighting is disabled'
do
before
do
stub_feature_flags
(
limited_diff_highlighting:
false
)
stub_feature_flags
(
diff_line_syntax_highlighting:
false
)
end
it
'blobs are highlighted as plain text with loading all data'
do
expect
(
diff_file
.
blob
).
to
receive
(
:load_all_data!
).
twice
code
=
%Q{ <span id="LC7" class="line" lang=""> def popen(cmd, path=nil)</span>
\n
}
expect
(
subject
[
2
].
rich_text
).
to
eq
(
code
)
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment