Remove cloud trait for license factory

It may conflict when a factory is calling `cloud` as an attr

Since it's used in one place, let's remove it

ee/spec/factories/licenses.rb

@@ -52,10 +52,6 @@ FactoryBot.define do
       trial { false }
     end
 
-    trait :cloud do
-      cloud { true }
-    end
-
     data do
       attrs = [:gitlab_license]
       attrs << :trial if trial

ee/spec/models/gitlab/seat_link_data_spec.rb

@@ -121,7 +121,7 @@ RSpec.describe Gitlab::SeatLinkData do
   describe '#should_sync_seats?' do
     let_it_be(:historical_data, refind: true) { create(:historical_data, recorded_at: timestamp) }
 
-    let(:license) { build(:license, :cloud) }
+    let(:license) { build(:license, cloud: true) }
 
     before do
       allow(License).to receive(:current).and_return(license)