Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
818d798b
Commit
818d798b
authored
Nov 11, 2020
by
Miguel Rincon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove ci_lint_creates_pipeline_with_dry_run flag
parent
f0e075d2
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
1 addition
and
27 deletions
+1
-27
config/feature_flags/development/ci_lint_creates_pipeline_with_dry_run.yml
...ags/development/ci_lint_creates_pipeline_with_dry_run.yml
+0
-8
lib/gitlab/ci/features.rb
lib/gitlab/ci/features.rb
+0
-4
lib/gitlab/ci/lint.rb
lib/gitlab/ci/lint.rb
+1
-1
spec/controllers/projects/ci/lints_controller_spec.rb
spec/controllers/projects/ci/lints_controller_spec.rb
+0
-14
No files found.
config/feature_flags/development/ci_lint_creates_pipeline_with_dry_run.yml
deleted
100644 → 0
View file @
f0e075d2
---
name
:
ci_lint_creates_pipeline_with_dry_run
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37828
rollout_issue_url
:
milestone
:
'
13.3'
type
:
development
group
:
group::continuous integration
default_enabled
:
true
lib/gitlab/ci/features.rb
View file @
818d798b
...
@@ -38,10 +38,6 @@ module Gitlab
...
@@ -38,10 +38,6 @@ module Gitlab
::
Feature
.
enabled?
(
:ci_disallow_to_create_merge_request_pipelines_in_target_project
,
target_project
)
::
Feature
.
enabled?
(
:ci_disallow_to_create_merge_request_pipelines_in_target_project
,
target_project
)
end
end
def
self
.
lint_creates_pipeline_with_dry_run?
(
project
)
::
Feature
.
enabled?
(
:ci_lint_creates_pipeline_with_dry_run
,
project
,
default_enabled:
true
)
end
def
self
.
project_transactionless_destroy?
(
project
)
def
self
.
project_transactionless_destroy?
(
project
)
Feature
.
enabled?
(
:project_transactionless_destroy
,
project
,
default_enabled:
false
)
Feature
.
enabled?
(
:project_transactionless_destroy
,
project
,
default_enabled:
false
)
end
end
...
...
lib/gitlab/ci/lint.rb
View file @
818d798b
...
@@ -24,7 +24,7 @@ module Gitlab
...
@@ -24,7 +24,7 @@ module Gitlab
end
end
def
validate
(
content
,
dry_run:
false
)
def
validate
(
content
,
dry_run:
false
)
if
dry_run
&&
Gitlab
::
Ci
::
Features
.
lint_creates_pipeline_with_dry_run?
(
@project
)
if
dry_run
simulate_pipeline_creation
(
content
)
simulate_pipeline_creation
(
content
)
else
else
static_validation
(
content
)
static_validation
(
content
)
...
...
spec/controllers/projects/ci/lints_controller_spec.rb
View file @
818d798b
...
@@ -123,20 +123,6 @@ RSpec.describe Projects::Ci::LintsController do
...
@@ -123,20 +123,6 @@ RSpec.describe Projects::Ci::LintsController do
subject
subject
end
end
context
'when dry_run feature flag is disabled'
do
before
do
stub_feature_flags
(
ci_lint_creates_pipeline_with_dry_run:
false
)
end
it_behaves_like
'returns a successful validation'
it
'runs validations through YamlProcessor'
do
expect
(
Gitlab
::
Ci
::
YamlProcessor
).
to
receive
(
:new
).
and_call_original
subject
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment