RSpec zero monkey patching mode

The plan for RSpec 4.0 is to disable monkey patching:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching:
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

ee/spec/features/projects/audit_events_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Audit Events', :js do
+RSpec.describe 'Projects > Audit Events', :js do
   let(:user) { create(:user) }
   let(:pete) { create(:user, name: 'Pete') }
   let(:project) { create(:project, :repository, namespace: user.namespace) }

ee/spec/features/projects/clusters/gcp_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Gcp Cluster', :js do
+RSpec.describe 'Gcp Cluster', :js do
   include GoogleApi::CloudPlatformHelpers
 
   let(:project) { create(:project) }

ee/spec/features/projects/clusters_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'EE Clusters', :js do
+RSpec.describe 'EE Clusters', :js do
   include GoogleApi::CloudPlatformHelpers
 
   let(:project) { create(:project) }

ee/spec/features/projects/custom_projects_template_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project' do
+RSpec.describe 'Project' do
   describe 'Custom instance-level projects templates' do
     let(:user) { create(:user) }
     let(:group) { create(:group) }

ee/spec/features/projects/environments/environments_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Environments page', :js do
+RSpec.describe 'Environments page', :js do
   let(:project) { create(:project, :repository) }
   let!(:environment) { create(:environment, name: 'production', project: project) }
   let(:user) { create(:user) }

ee/spec/features/projects/feature_flag_user_lists/user_edits_feature_flag_user_list_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User edits feature flag user list', :js do
+RSpec.describe 'User edits feature flag user list', :js do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
 

ee/spec/features/projects/feature_flag_user_lists/user_sees_feature_flag_user_list_details_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User sees feature flag user list details', :js do
+RSpec.describe 'User sees feature flag user list details', :js do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
 

ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User creates feature flag', :js do
+RSpec.describe 'User creates feature flag', :js do
   include FeatureFlagHelpers
 
   let(:user) { create(:user) }

ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User deletes feature flag', :js do
+RSpec.describe 'User deletes feature flag', :js do
   include FeatureFlagHelpers
 
   let(:user) { create(:user) }

ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User sees feature flag list', :js do
+RSpec.describe 'User sees feature flag list', :js do
   include FeatureFlagHelpers
 
   let(:user) { create(:user) }

ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User updates feature flag', :js do
+RSpec.describe 'User updates feature flag', :js do
   include FeatureFlagHelpers
 
   let(:user) { create(:user) }

ee/spec/features/projects/insights_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project Insights' do
+RSpec.describe 'Project Insights' do
   it_behaves_like 'Insights page' do
     let_it_be(:entity) { create(:project) }
     let(:route) { url_for([entity.namespace, entity, :insights]) }

ee/spec/features/projects/issues/user_creates_issue_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "User creates issue", :js do
+RSpec.describe "User creates issue", :js do
   let(:project) { create(:project_empty_repo, :public) }
   let(:user) { create(:user) }
 

ee/spec/features/projects/jobs_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require 'tempfile'
 
-describe 'Jobs', :clean_gitlab_redis_shared_state do
+RSpec.describe 'Jobs', :clean_gitlab_redis_shared_state do
   let(:user) { create(:user) }
   let(:user_access_level) { :developer }
   let(:pipeline) { create(:ci_pipeline, project: project) }

ee/spec/features/projects/kerberos_clone_instructions_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Kerberos clone instructions', :js do
+RSpec.describe 'Kerberos clone instructions', :js do
   include MobileHelpers
 
   let(:project) { create(:project, :empty_repo) }

ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'EE > Projects > Licenses > Maintainer views policies', :js do
+RSpec.describe 'EE > Projects > Licenses > Maintainer views policies', :js do
   let_it_be(:project) { create(:project) }
   let_it_be(:maintainer) do
     create(:user).tap do |user|

ee/spec/features/projects/members/invite_group_and_members_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project > Members > Invite group and members', :js do
+RSpec.describe 'Project > Members > Invite group and members', :js do
   include Select2Helper
   include ActionView::Helpers::DateHelper
 

ee/spec/features/projects/members/member_is_removed_from_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Members > Member is removed from project' do
+RSpec.describe 'Projects > Members > Member is removed from project' do
   let(:user) { create(:user) }
   let(:project) { create(:project) }
   let(:other_user) { create(:user) }

ee/spec/features/projects/members/member_leaves_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Members > Member leaves project' do
+RSpec.describe 'Projects > Members > Member leaves project' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }
 

ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User approves a merge request', :js do
+RSpec.describe 'User approves a merge request', :js do
   let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
   let(:project) { create(:project, :repository, approvals_before_merge: 1) }
   let(:user) { create(:user) }

ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Merge Requests > User edits a merge request' do
+RSpec.describe 'Projects > Merge Requests > User edits a merge request' do
   let(:user) { create(:user) }
 
   before do

ee/spec/features/projects/milestones/milestone_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Milestones on EE' do
+RSpec.describe 'Milestones on EE' do
   let(:user) { create(:user) }
   let(:project) { create(:project, name: 'test', namespace: user.namespace) }
   let(:milestone) { create(:milestone, project: project, start_date: Date.today, due_date: 7.days.from_now) }

ee/spec/features/projects/mirror_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project mirror', :js do
+RSpec.describe 'Project mirror', :js do
   include ReactiveCachingHelpers
 
   let(:project) { create(:project, :repository, creator: user, name: 'Victorialand') }

ee/spec/features/projects/navbar_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project navbar' do
+RSpec.describe 'Project navbar' do
   include NavbarStructureHelper
 
   include_context 'project navbar structure'

ee/spec/features/projects/new_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'New project' do
+RSpec.describe 'New project' do
   let(:user) { create(:admin) }
 
   before do

ee/spec/features/projects/package_files_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'PackageFiles' do
+RSpec.describe 'PackageFiles' do
   let(:user) { create(:user) }
   let(:project) { create(:project) }
   let!(:package) { create(:maven_package, project: project) }

ee/spec/features/projects/packages_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Packages' do
+RSpec.describe 'Packages' do
   let_it_be(:user) { create(:user) }
   let_it_be(:project) { create(:project) }
 

ee/spec/features/projects/path_locks_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Path Locks', :js do
+RSpec.describe 'Path Locks', :js do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository, namespace: user.namespace) }
   let(:tree_path) { project_tree_path(project, project.repository.root_ref) }

ee/spec/features/projects/pipelines/pipeline_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Pipeline', :js do
+RSpec.describe 'Pipeline', :js do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }
 

ee/spec/features/projects/push_rules_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Push Rules', :js do
+RSpec.describe 'Projects > Push Rules', :js do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository, namespace: user.namespace) }
   let(:foo) {{ reject_unsigned_commits: 'Reject unsigned commits' }}

ee/spec/features/projects/requirements_management/requirements_list_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Requirements list', :js do
+RSpec.describe 'Requirements list', :js do
   let_it_be(:user) { create(:user) }
   let_it_be(:user_guest) { create(:user) }
   let_it_be(:project) { create(:project, :repository) }

ee/spec/features/projects/services/prometheus_custom_metrics_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Prometheus custom metrics', :js do
+RSpec.describe 'Prometheus custom metrics', :js do
   include PrometheusHelpers
 
   include_context 'project service activation'

ee/spec/features/projects/services/user_activates_github_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User activates GitHub Service' do
+RSpec.describe 'User activates GitHub Service' do
   include_context 'project service activation'
 
   context 'without a license' do

ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project settings > [EE] repository' do
+RSpec.describe 'Project settings > [EE] repository' do
   include Select2Helper
 
   let(:user) { create(:user) }

ee/spec/features/projects/settings/issues_settings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project settings > Issues', :js do
+RSpec.describe 'Project settings > Issues', :js do
   let(:project) { create(:project, :public) }
   let(:user) { create(:user) }
 

ee/spec/features/projects/settings/merge_requests_settings_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe 'Project settings > [EE] Merge Requests', :js do
+RSpec.describe 'Project settings > [EE] Merge Requests', :js do
   include GitlabRoutingHelper
   include FeatureApprovalHelper
 

ee/spec/features/projects/settings/packages_settings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Settings > Packages', :js do
+RSpec.describe 'Projects > Settings > Packages', :js do
   let(:project) { create(:project) }
   let(:user) { create(:user) }
 

ee/spec/features/projects/settings/pipeline_subscriptions_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project Subscriptions', :js do
+RSpec.describe 'Project Subscriptions', :js do
   let(:project) { create(:project, :public, :repository) }
   let(:upstream_project) { create(:project, :public, :repository) }
   let(:user) { create(:user) }

ee/spec/features/projects/settings/protected_environments_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Protected Environments' do
+RSpec.describe 'Protected Environments' do
   let(:project) { create(:project, :repository) }
   let(:user) { create(:user) }
   let(:environments) { %w(production development staging test) }

ee/spec/features/projects/settings/push_rules_settings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project settings > [EE] repository' do
+RSpec.describe 'Project settings > [EE] repository' do
   let(:user) { create(:user) }
   let(:project) { create(:project_empty_repo) }
 

ee/spec/features/projects/settings/service_desk_setting_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Service Desk Setting', :js do
+RSpec.describe 'Service Desk Setting', :js do
   let(:project) { create(:project_empty_repo, :private, service_desk_enabled: false) }
   let(:presenter) { project.present(current_user: user) }
   let(:user) { create(:user) }

ee/spec/features/projects/settings/slack_application_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Slack application' do
+RSpec.describe 'Slack application' do
   let(:project) { create(:project) }
   let(:user) { create(:user) }
   let(:role) { :developer }

ee/spec/features/projects/settings/user_manages_approval_settings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'EE > Projects > Settings > User manages approval rule settings' do
+RSpec.describe 'EE > Projects > Settings > User manages approval rule settings' do
   let(:project) { create(:project) }
   let(:user) { project.owner }
   let(:path) { edit_project_path(project) }

ee/spec/features/projects/settings/user_manages_issues_template_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'EE > Projects > Settings > User manages issue template' do
+RSpec.describe 'EE > Projects > Settings > User manages issue template' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :public, :repository, namespace: user.namespace) }
 

ee/spec/features/projects/settings/user_manages_members_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "User manages members" do
+RSpec.describe "User manages members" do
   let_it_be(:group) { create(:group) }
   let_it_be(:project) { create(:project, namespace: group) }
   let_it_be(:user) { create(:user) }

ee/spec/features/projects/settings/user_manages_merge_pipelines_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'User manages merge pipelines option', :js do
+RSpec.describe 'User manages merge pipelines option', :js do
   let(:project) { create(:project) }
   let(:user) { create(:user) }
 

ee/spec/features/projects/settings/user_manages_merge_requests_template_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'EE > Projects > Settings > User manages merge requests template' do
+RSpec.describe 'EE > Projects > Settings > User manages merge requests template' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :public, :repository, namespace: user.namespace) }
 

ee/spec/features/projects/show/developer_views_empty_project_instructions_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Projects > Show > Developer views empty project instructions' do
+RSpec.describe 'Projects > Show > Developer views empty project instructions' do
   let(:project) { create(:project, :empty_repo) }
   let(:developer) { create(:user) }
 

ee/spec/features/projects/show_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project show page', :feature do
+RSpec.describe 'Project show page', :feature do
   let_it_be(:user) { create(:user) }
 
   describe 'stat button existence' do

ee/spec/features/projects/tracings_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Tracings Content Security Policy' do
+RSpec.describe 'Tracings Content Security Policy' do
   let_it_be(:user) { create(:user) }
   let(:project) { create(:project) }
 

ee/spec/features/projects/user_applies_custom_file_template_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project', :js do
+RSpec.describe 'Project', :js do
   let(:template_text) { 'Custom license template content' }
   let(:group) { create(:group) }
   let(:template_project) { create(:project, :custom_repo, namespace: group, files: { 'LICENSE/custom.txt' => template_text }) }

ee/spec/features/projects/view_blob_with_code_owners_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'File blob > Code owners', :js do
+RSpec.describe 'File blob > Code owners', :js do
   let(:project) { create(:project, :private, :repository) }
   let(:user) { project.owner }
   let(:code_owner) { create(:user, username: 'documentation-owner') }

ee/spec/features/promotion_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Promotions', :js do
+RSpec.describe 'Promotions', :js do
   let(:admin) { create(:admin) }
   let(:user) { create(:user) }
   let(:otherdeveloper) { create(:user, name: 'TheOtherDeveloper') }

ee/spec/features/protected_branches_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Protected Branches', :js do
+RSpec.describe 'Protected Branches', :js do
   include ProtectedBranchHelpers
 
   let(:user) { create(:user, :admin) }

ee/spec/features/protected_tags_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Protected Tags', :js do
+RSpec.describe 'Protected Tags', :js do
   include ProtectedTagHelpers
 
   let(:user) { create(:user, :admin) }

ee/spec/features/read_only_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Geo read-only message', :geo do
+RSpec.describe 'Geo read-only message', :geo do
   include ::EE::GeoHelpers
 
   let_it_be(:user) { create(:user) }

ee/spec/features/registrations/new_group_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'New group screen', :js do
+RSpec.describe 'New group screen', :js do
   let_it_be(:user) { create(:user) }
 
   before do

ee/spec/features/registrations/new_project_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'New project screen', :js do
+RSpec.describe 'New project screen', :js do
   let_it_be(:user) { create(:user) }
   let_it_be(:namespace) { create(:group) }
   let(:in_subscription_flow) { false }

ee/spec/features/registrations/welcome_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Welcome screen', :js do
+RSpec.describe 'Welcome screen', :js do
   let_it_be(:user) { create(:user) }
 
   let(:in_invitation_flow) { false }

ee/spec/features/search/elastic/global_search_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Global elastic search', :elastic, :sidekiq_inline do
+RSpec.describe 'Global elastic search', :elastic, :sidekiq_inline do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository, :wiki_repo, namespace: user.namespace) }
 
@@ -265,7 +265,7 @@ describe 'Global elastic search', :elastic, :sidekiq_inline do
   end
 end
 
-describe 'Global elastic search redactions', :elastic do
+RSpec.describe 'Global elastic search redactions', :elastic do
   it_behaves_like 'a redacted search results page' do
     let(:search_path) { explore_root_path }
   end

ee/spec/features/search/elastic/group_search_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Group elastic search', :js, :elastic, :sidekiq_might_not_need_inline do
+RSpec.describe 'Group elastic search', :js, :elastic, :sidekiq_might_not_need_inline do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
   let(:project) { create(:project, :repository, :wiki_repo, namespace: group) }
@@ -92,7 +92,7 @@ describe 'Group elastic search', :js, :elastic, :sidekiq_might_not_need_inline d
   end
 end
 
-describe 'Group elastic search redactions', :elastic do
+RSpec.describe 'Group elastic search redactions', :elastic do
   it_behaves_like 'a redacted search results page' do
     let(:search_path) { group_path(public_group) }
   end

ee/spec/features/search/elastic/project_search_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Project elastic search', :js, :elastic do
+RSpec.describe 'Project elastic search', :js, :elastic do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository, :wiki_repo, namespace: user.namespace) }
 
@@ -86,7 +86,7 @@ describe 'Project elastic search', :js, :elastic do
   end
 end
 
-describe 'Project elastic search redactions', :elastic do
+RSpec.describe 'Project elastic search redactions', :elastic do
   it_behaves_like 'a redacted search results page' do
     let(:search_path) { project_path(public_restricted_project) }
   end

ee/spec/features/search/elastic/snippet_search_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Snippet elastic search', :js, :elastic, :aggregate_failures, :sidekiq_might_not_need_inline do
+RSpec.describe 'Snippet elastic search', :js, :elastic, :aggregate_failures, :sidekiq_might_not_need_inline do
   let(:public_project) { create(:project, :public) }
   let(:authorized_user) { create(:user) }
   let(:authorized_project) { create(:project, namespace: authorized_user.namespace) }

ee/spec/features/security/admin_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Admin::Projects" do
+RSpec.describe "Admin::Projects" do
   include AccessMatchers
 
   describe "GET /admin/projects" do

ee/spec/features/security/dashboard_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Dashboard access" do
+RSpec.describe "Dashboard access" do
   include AccessMatchers
 
   describe "GET /dashboard" do

ee/spec/features/security/group/internal_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Internal Group access' do
+RSpec.describe '[EE] Internal Group access' do
   include AccessMatchers
 
   let_it_be(:group)   { create(:group, :internal) }

ee/spec/features/security/group/private_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Private Group access' do
+RSpec.describe '[EE] Private Group access' do
   include AccessMatchers
 
   let_it_be(:group)   { create(:group, :private) }

ee/spec/features/security/group/public_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Public Group access' do
+RSpec.describe '[EE] Public Group access' do
   include AccessMatchers
 
   let_it_be(:group)   { create(:group, :public) }

ee/spec/features/security/profile_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Profile access" do
+RSpec.describe "Profile access" do
   include AccessMatchers
 
   describe "GET /profile/keys" do

ee/spec/features/security/project/internal_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Internal Project Access' do
+RSpec.describe '[EE] Internal Project Access' do
   include AccessMatchers
 
   let_it_be(:project) { create(:project, :internal, :repository) }

ee/spec/features/security/project/private_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Private Project Access' do
+RSpec.describe '[EE] Private Project Access' do
   include AccessMatchers
 
   let_it_be(:project) { create(:project, :private, :repository) }

ee/spec/features/security/project/public_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe '[EE] Public Project Access' do
+RSpec.describe '[EE] Public Project Access' do
   include AccessMatchers
 
   let_it_be(:project) { create(:project, :public, :repository) }

ee/spec/features/security/project/snippet/internal_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Internal Project Snippets Access" do
+RSpec.describe "Internal Project Snippets Access" do
   include AccessMatchers
 
   let(:project) { create(:project, :internal) }

ee/spec/features/security/project/snippet/private_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Private Project Snippets Access" do
+RSpec.describe "Private Project Snippets Access" do
   include AccessMatchers
 
   let(:project) { create(:project, :private) }

ee/spec/features/security/project/snippet/public_access_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe "Public Project Snippets Access" do
+RSpec.describe "Public Project Snippets Access" do
   include AccessMatchers
 
   let(:project) { create(:project, :public) }

ee/spec/features/signup_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Signup on EE' do
+RSpec.describe 'Signup on EE' do
   let(:user_attrs) { attributes_for(:user) }
 
   context 'for Gitlab.com' do

ee/spec/features/subscriptions/groups/edit_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Welcome screen', :js do
+RSpec.describe 'Welcome screen', :js do
   let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group) }
 

ee/spec/features/subscriptions_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Subscriptions Content Security Policy' do
+RSpec.describe 'Subscriptions Content Security Policy' do
   subject { response_headers['Content-Security-Policy'] }
 
   let_it_be(:default_csp_values) { "'self' https://some-cdn.test" }

ee/spec/features/survey_responses_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Responses' do
+RSpec.describe 'Responses' do
   it 'Shows a friendly message' do
     visit survey_responses_path
 

ee/spec/features/trial_registrations/signin_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Trial Sign In' do
+RSpec.describe 'Trial Sign In' do
   let(:user) { create(:user) }
 
   describe 'on GitLab.com' do

ee/spec/features/trial_registrations/signup_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Trial Sign Up', :js do
+RSpec.describe 'Trial Sign Up', :js do
   let(:user_attrs) { attributes_for(:user, first_name: 'GitLab', last_name: 'GitLab') }
 
   describe 'on GitLab.com' do

ee/spec/features/trials/capture_lead_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Trial Capture Lead', :js do
+RSpec.describe 'Trial Capture Lead', :js do
   include Select2Helper
   let(:user) { create(:user) }
 

ee/spec/features/trials/select_namespace_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Trial Select Namespace', :js do
+RSpec.describe 'Trial Select Namespace', :js do
   include Select2Helper
 
   let(:new_group_name) { 'GitLab' }

ee/spec/features/trials/show_trial_banner_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Show trial banner', :js do
+RSpec.describe 'Show trial banner', :js do
   include StubRequests
 
   let!(:user) { create(:user) }

ee/spec/features/user_unsubscribes_from_admin_notifications_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe "Admin unsubscribes from notification" do
+RSpec.describe "Admin unsubscribes from notification" do
   let_it_be(:user) { create(:user) }
   let_it_be(:urlsafe_email) { Base64.urlsafe_encode64(user.email) }
 

ee/spec/features/users/login_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Login' do
+RSpec.describe 'Login' do
   include LdapHelpers
   include UserLoginHelper
   include DeviseHelpers

ee/spec/features/users/signup_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'Signup' do
+RSpec.describe 'Signup' do
   context 'almost there page' do
     context 'when public visibility is restricted' do
       before do

ee/spec/finders/analytics/cycle_analytics/stage_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Analytics::CycleAnalytics::StageFinder do
+RSpec.describe Analytics::CycleAnalytics::StageFinder do
   let_it_be(:group) { create(:group) }
   let(:stage_id) { { id: Gitlab::Analytics::CycleAnalytics::DefaultStages.names.first } }
 

ee/spec/finders/approval_rules/group_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ApprovalRules::GroupFinder do
+RSpec.describe ApprovalRules::GroupFinder do
   let(:rule) { create(:approval_project_rule) }
   let(:user) { create(:user) }
 

ee/spec/finders/audit_log_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe AuditLogFinder do
+RSpec.describe AuditLogFinder do
   let_it_be(:group) { create(:group) }
   let_it_be(:subgroup) { create(:group, parent: group) }
   let_it_be(:project) { create(:project, namespace: group) }

ee/spec/finders/auth/group_saml_identity_finder_spec.rb

 # frozen_string_literal: true
 require 'spec_helper'
 
-describe Auth::GroupSamlIdentityFinder do
+RSpec.describe Auth::GroupSamlIdentityFinder do
   let(:uid) { 1234 }
   let!(:identity) { create(:group_saml_identity, extern_uid: uid) }
   let(:saml_provider) { identity.saml_provider }

ee/spec/finders/autocomplete/project_invited_groups_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Autocomplete::ProjectInvitedGroupsFinder do
+RSpec.describe Autocomplete::ProjectInvitedGroupsFinder do
   let(:user) { create(:user) }
 
   describe '#execute' do

ee/spec/finders/boards/milestones_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::MilestonesFinder do
+RSpec.describe Boards::MilestonesFinder do
   describe '#execute' do
     let(:group) { create(:group) }
     let(:nested_group) { create(:group, parent: group) }

ee/spec/finders/boards/users_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Boards::UsersFinder do
+RSpec.describe Boards::UsersFinder do
   describe '#execute' do
     subject { described_class.new(board) }
 

ee/spec/finders/clusters/environments_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Clusters::EnvironmentsFinder, '#execute' do
+RSpec.describe Clusters::EnvironmentsFinder, '#execute' do
   let(:current_user) { create(:user) }
   let(:last_deployment) { create(:deployment, :success, :on_cluster) }
   let(:cluster) { last_deployment.cluster }

ee/spec/finders/ee/autocomplete/users_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Autocomplete::UsersFinder do
+RSpec.describe Autocomplete::UsersFinder do
   let(:current_user) { create(:user) }
   let(:group) { create(:group) }
   let(:saml_provider) { create(:saml_provider, group: group) }

ee/spec/finders/ee/fork_targets_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ForkTargetsFinder do
+RSpec.describe ForkTargetsFinder do
   subject(:finder) { described_class.new(project, user) }
 
   let(:project) { create :project, namespace: project_group }

ee/spec/finders/ee/group_members_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe GroupMembersFinder do
+RSpec.describe GroupMembersFinder do
   subject(:finder) { described_class.new(group) }
 
   let(:group) { create :group }

ee/spec/finders/ee/projects_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe ProjectsFinder do
+RSpec.describe ProjectsFinder do
   describe '#execute' do
     let_it_be(:user) { create(:user) }
     let(:finder) { described_class.new(current_user: user, params: params, project_ids_relation: project_ids_relation) }

ee/spec/finders/epics_finder_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe EpicsFinder do
+RSpec.describe EpicsFinder do
   let_it_be(:user) { create(:user) }
   let_it_be(:search_user) { create(:user) }
   let_it_be(:group) { create(:group, :private) }