Commit 854b6aca authored by Mike Greiling's avatar Mike Greiling

Merge branch 'winh-eslint-promise/no-nesting' into 'master'

Narrow down violation of promise/no-nesting ESLint rule

See merge request gitlab-org/gitlab!17683
parents 6cae55a9 2dc51b6f
...@@ -45,7 +45,6 @@ rules: ...@@ -45,7 +45,6 @@ rules:
no-jquery/no-serialize: error no-jquery/no-serialize: error
promise/always-return: off promise/always-return: off
promise/no-callback-in-promise: off promise/no-callback-in-promise: off
promise/no-nesting: off
overrides: overrides:
files: files:
- '**/spec/**/*' - '**/spec/**/*'
......
rules:
# https://gitlab.com/gitlab-org/gitlab/issues/33024
promise/no-nesting: off
...@@ -124,6 +124,8 @@ describe('ee/ide/lib/mirror', () => { ...@@ -124,6 +124,8 @@ describe('ee/ide/lib/mirror', () => {
it('disconnects when connected again', () => { it('disconnects when connected again', () => {
const result = connection const result = connection
.then(() => { .then(() => {
// https://gitlab.com/gitlab-org/gitlab/issues/33024
// eslint-disable-next-line promise/no-nesting
mirror.connect(TEST_PATH).catch(() => {}); mirror.connect(TEST_PATH).catch(() => {});
}) })
.then(() => { .then(() => {
......
rules:
# https://gitlab.com/gitlab-org/gitlab/issues/33025
promise/no-nesting: off
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment