Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8598100a
Commit
8598100a
authored
Dec 06, 2021
by
Eugenia Grieff
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not allow issue_id to be nil
In requirement model
parent
a648c45e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
8 deletions
+2
-8
ee/app/models/requirements_management/requirement.rb
ee/app/models/requirements_management/requirement.rb
+1
-1
ee/spec/models/requirements_management/requirement_spec.rb
ee/spec/models/requirements_management/requirement_spec.rb
+1
-7
No files found.
ee/app/models/requirements_management/requirement.rb
View file @
8598100a
...
...
@@ -27,7 +27,7 @@ module RequirementsManagement
# This will be removed in https://gitlab.com/gitlab-org/gitlab/-/issues/329432
belongs_to
:requirement_issue
,
class_name:
'Issue'
,
foreign_key: :issue_id
,
dependent: :destroy
# rubocop:disable Cop/ActiveRecordDependent
validates
:issue_id
,
uniqueness:
true
,
allow_nil:
true
validates
:issue_id
,
uniqueness:
true
has_many
:test_reports
,
inverse_of: :requirement
has_many
:recent_test_reports
,
->
{
order
(
created_at: :desc
)
},
class_name:
'TestReport'
,
inverse_of: :requirement
...
...
ee/spec/models/requirements_management/requirement_spec.rb
View file @
8598100a
...
...
@@ -46,13 +46,7 @@ RSpec.describe RequirementsManagement::Requirement do
describe
'validations'
do
subject
{
build
(
:requirement
)
}
context
'with requirement issue'
do
let
(
:ri
)
{
create
(
:requirement_issue
)
}
subject
{
build
(
:requirement
,
requirement_issue:
ri
)
}
it
{
is_expected
.
to
validate_uniqueness_of
(
:issue_id
).
allow_nil
}
end
it
{
is_expected
.
to
validate_uniqueness_of
(
:issue_id
)
}
it
'is limited to a unique requirement_issue'
do
requirement_issue
=
create
(
:requirement_issue
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment