Merge branch 'mw-remove-analytics-similarity-feature-flag' into 'master'

Remove analytics_similarity_feature flag

See merge request gitlab-org/gitlab!44582

ee/app/assets/javascripts/analytics/cycle_analytics/index.js

@@ -23,7 +23,6 @@ export default () => {
     cycleAnalyticsScatterplotEnabled: hasDurationChart = false,
     valueStreamAnalyticsPathNavigation: hasPathNavigation = false,
     valueStreamAnalyticsCreateMultipleValueStreams: hasCreateMultipleValueStreams = false,
-    analyticsSimilaritySearch: hasAnalyticsSimilaritySearch = false,
   } = gon?.features;
 
   const {
@@ -43,7 +42,6 @@ export default () => {
       hasDurationChart,
       hasPathNavigation,
       hasCreateMultipleValueStreams,
-      hasAnalyticsSimilaritySearch,
     },
   });
 

ee/app/controllers/groups/analytics/cycle_analytics_controller.rb

@@ -16,7 +16,6 @@ class Groups::Analytics::CycleAnalyticsController < Groups::Analytics::Applicati
     push_frontend_feature_flag(:cycle_analytics_scatterplot_enabled, default_enabled: true)
     push_frontend_feature_flag(:value_stream_analytics_path_navigation, @group)
     push_frontend_feature_flag(:value_stream_analytics_create_multiple_value_streams, default_enabled: true)
-    push_frontend_feature_flag(:analytics_similarity_search, @group, default_enabled: true)
     render_403 unless can?(current_user, :read_group_cycle_analytics, @group)
   end
 

ee/app/controllers/groups/analytics/productivity_analytics_controller.rb

@@ -18,7 +18,6 @@ class Groups::Analytics::ProductivityAnalyticsController < Groups::Analytics::Ap
   }
   before_action -> {
     push_frontend_feature_flag(:productivity_analytics_scatterplot_enabled, default_enabled: true)
-    push_frontend_feature_flag(:analytics_similarity_search, @group, default_enabled: true)
   }
 
   before_action :validate_params, only: :show, if: -> { request.format.json? }

ee/config/feature_flags/development/analytics_similarity_search.yml

----
-name: analytics_similarity_search
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37700
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38675
-group: group::analytics
-type: development
-default_enabled: true

ee/spec/features/groups/analytics/cycle_analytics/cycle_analytics_spec.rb

@@ -19,8 +19,7 @@ RSpec.describe 'Group value stream analytics' do
 
     expect(page).to have_pushed_frontend_feature_flags(
       cycleAnalyticsScatterplotEnabled: true,
-      valueStreamAnalyticsPathNavigation: true,
-      analyticsSimilaritySearch: true
+      valueStreamAnalyticsPathNavigation: true
     )
   end