Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a865ba3c
Commit
a865ba3c
authored
Oct 07, 2020
by
Martin Wortschack
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove analytics_similarity_search feature flag
parent
6b989fbf
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
1 addition
and
13 deletions
+1
-13
ee/app/assets/javascripts/analytics/cycle_analytics/index.js
ee/app/assets/javascripts/analytics/cycle_analytics/index.js
+0
-2
ee/app/controllers/groups/analytics/cycle_analytics_controller.rb
...ontrollers/groups/analytics/cycle_analytics_controller.rb
+0
-1
ee/app/controllers/groups/analytics/productivity_analytics_controller.rb
...ers/groups/analytics/productivity_analytics_controller.rb
+0
-1
ee/config/feature_flags/development/analytics_similarity_search.yml
...feature_flags/development/analytics_similarity_search.yml
+0
-7
ee/spec/features/groups/analytics/cycle_analytics/cycle_analytics_spec.rb
.../groups/analytics/cycle_analytics/cycle_analytics_spec.rb
+1
-2
No files found.
ee/app/assets/javascripts/analytics/cycle_analytics/index.js
View file @
a865ba3c
...
...
@@ -23,7 +23,6 @@ export default () => {
cycleAnalyticsScatterplotEnabled
:
hasDurationChart
=
false
,
valueStreamAnalyticsPathNavigation
:
hasPathNavigation
=
false
,
valueStreamAnalyticsCreateMultipleValueStreams
:
hasCreateMultipleValueStreams
=
false
,
analyticsSimilaritySearch
:
hasAnalyticsSimilaritySearch
=
false
,
}
=
gon
?.
features
;
const
{
...
...
@@ -43,7 +42,6 @@ export default () => {
hasDurationChart
,
hasPathNavigation
,
hasCreateMultipleValueStreams
,
hasAnalyticsSimilaritySearch
,
},
});
...
...
ee/app/controllers/groups/analytics/cycle_analytics_controller.rb
View file @
a865ba3c
...
...
@@ -16,7 +16,6 @@ class Groups::Analytics::CycleAnalyticsController < Groups::Analytics::Applicati
push_frontend_feature_flag
(
:cycle_analytics_scatterplot_enabled
,
default_enabled:
true
)
push_frontend_feature_flag
(
:value_stream_analytics_path_navigation
,
@group
)
push_frontend_feature_flag
(
:value_stream_analytics_create_multiple_value_streams
,
default_enabled:
true
)
push_frontend_feature_flag
(
:analytics_similarity_search
,
@group
,
default_enabled:
true
)
render_403
unless
can?
(
current_user
,
:read_group_cycle_analytics
,
@group
)
end
...
...
ee/app/controllers/groups/analytics/productivity_analytics_controller.rb
View file @
a865ba3c
...
...
@@ -18,7 +18,6 @@ class Groups::Analytics::ProductivityAnalyticsController < Groups::Analytics::Ap
}
before_action
->
{
push_frontend_feature_flag
(
:productivity_analytics_scatterplot_enabled
,
default_enabled:
true
)
push_frontend_feature_flag
(
:analytics_similarity_search
,
@group
,
default_enabled:
true
)
}
before_action
:validate_params
,
only: :show
,
if:
->
{
request
.
format
.
json?
}
...
...
ee/config/feature_flags/development/analytics_similarity_search.yml
deleted
100644 → 0
View file @
6b989fbf
---
name
:
analytics_similarity_search
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37700
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38675
group
:
group::analytics
type
:
development
default_enabled
:
true
ee/spec/features/groups/analytics/cycle_analytics/cycle_analytics_spec.rb
View file @
a865ba3c
...
...
@@ -19,8 +19,7 @@ RSpec.describe 'Group value stream analytics' do
expect
(
page
).
to
have_pushed_frontend_feature_flags
(
cycleAnalyticsScatterplotEnabled:
true
,
valueStreamAnalyticsPathNavigation:
true
,
analyticsSimilaritySearch:
true
valueStreamAnalyticsPathNavigation:
true
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment