Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
86a3cab3
Commit
86a3cab3
authored
Apr 05, 2021
by
Amy Qualls
Committed by
Craig Norris
Apr 05, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix more mis-capitalizations of Merge Request
parent
50912ad6
Changes
19
Hide whitespace changes
Inline
Side-by-side
Showing
19 changed files
with
35 additions
and
36 deletions
+35
-36
app/finders/merge_requests/by_approvals_finder.rb
app/finders/merge_requests/by_approvals_finder.rb
+4
-4
app/graphql/types/merge_request_state_enum.rb
app/graphql/types/merge_request_state_enum.rb
+1
-1
app/graphql/types/user_type.rb
app/graphql/types/user_type.rb
+3
-3
app/models/timelog.rb
app/models/timelog.rb
+2
-2
app/presenters/dev_ops_report/metric_presenter.rb
app/presenters/dev_ops_report/metric_presenter.rb
+1
-1
app/views/groups/merge_requests.html.haml
app/views/groups/merge_requests.html.haml
+1
-1
app/views/shared/milestones/_milestone.html.haml
app/views/shared/milestones/_milestone.html.haml
+1
-1
app/views/shared/milestones/_tabs.html.haml
app/views/shared/milestones/_tabs.html.haml
+1
-1
app/views/shared/projects/_project.html.haml
app/views/shared/projects/_project.html.haml
+1
-1
danger/pipeline/Dangerfile
danger/pipeline/Dangerfile
+2
-2
doc/api/graphql/reference/index.md
doc/api/graphql/reference/index.md
+4
-4
lib/banzai/filter/abstract_reference_filter.rb
lib/banzai/filter/abstract_reference_filter.rb
+1
-1
lib/support/nginx/gitlab
lib/support/nginx/gitlab
+2
-2
lib/support/nginx/gitlab-ssl
lib/support/nginx/gitlab-ssl
+2
-2
locale/gitlab.pot
locale/gitlab.pot
+2
-2
spec/features/dashboard/milestones_spec.rb
spec/features/dashboard/milestones_spec.rb
+1
-1
spec/features/groups/milestone_spec.rb
spec/features/groups/milestone_spec.rb
+3
-3
spec/features/milestones/user_views_milestone_spec.rb
spec/features/milestones/user_views_milestone_spec.rb
+2
-2
spec/features/milestones/user_views_milestones_spec.rb
spec/features/milestones/user_views_milestones_spec.rb
+1
-2
No files found.
app/finders/merge_requests/by_approvals_finder.rb
View file @
86a3cab3
...
@@ -60,14 +60,14 @@ module MergeRequests
...
@@ -60,14 +60,14 @@ module MergeRequests
ids
.
first
.
to_s
.
downcase
==
label
||
usernames
.
map
(
&
:downcase
).
include?
(
label
)
ids
.
first
.
to_s
.
downcase
==
label
||
usernames
.
map
(
&
:downcase
).
include?
(
label
)
end
end
# Merge
R
equests without any approval
# Merge
r
equests without any approval
#
#
# @param [ActiveRecord::Relation] items
# @param [ActiveRecord::Relation] items
def
without_approvals
(
items
)
def
without_approvals
(
items
)
items
.
without_approvals
items
.
without_approvals
end
end
# Merge
R
equests with any number of approvals
# Merge
r
equests with any number of approvals
#
#
# @param [ActiveRecord::Relation] items the activerecord relation
# @param [ActiveRecord::Relation] items the activerecord relation
def
with_any_approvals
(
items
)
def
with_any_approvals
(
items
)
...
@@ -76,14 +76,14 @@ module MergeRequests
...
@@ -76,14 +76,14 @@ module MergeRequests
])
])
end
end
# Merge
R
equests approved by given usernames
# Merge
r
equests approved by given usernames
#
#
# @param [ActiveRecord::Relation] items the activerecord relation
# @param [ActiveRecord::Relation] items the activerecord relation
def
find_approved_by_names
(
items
)
def
find_approved_by_names
(
items
)
items
.
approved_by_users_with_usernames
(
*
usernames
)
items
.
approved_by_users_with_usernames
(
*
usernames
)
end
end
# Merge
R
equests approved by given user IDs
# Merge
r
equests approved by given user IDs
#
#
# @param [ActiveRecord::Relation] items the activerecord relation
# @param [ActiveRecord::Relation] items the activerecord relation
def
find_approved_by_ids
(
items
)
def
find_approved_by_ids
(
items
)
...
...
app/graphql/types/merge_request_state_enum.rb
View file @
86a3cab3
...
@@ -5,6 +5,6 @@ module Types
...
@@ -5,6 +5,6 @@ module Types
graphql_name
'MergeRequestState'
graphql_name
'MergeRequestState'
description
'State of a GitLab merge request'
description
'State of a GitLab merge request'
value
'merged'
,
description:
"Merge
R
equest has been merged."
value
'merged'
,
description:
"Merge
r
equest has been merged."
end
end
end
end
app/graphql/types/user_type.rb
View file @
86a3cab3
...
@@ -83,13 +83,13 @@ module Types
...
@@ -83,13 +83,13 @@ module Types
# Merge request field: MRs can be authored, assigned, or assigned-for-review:
# Merge request field: MRs can be authored, assigned, or assigned-for-review:
field
:authored_merge_requests
,
field
:authored_merge_requests
,
resolver:
Resolvers
::
AuthoredMergeRequestsResolver
,
resolver:
Resolvers
::
AuthoredMergeRequestsResolver
,
description:
'Merge
R
equests authored by the user.'
description:
'Merge
r
equests authored by the user.'
field
:assigned_merge_requests
,
field
:assigned_merge_requests
,
resolver:
Resolvers
::
AssignedMergeRequestsResolver
,
resolver:
Resolvers
::
AssignedMergeRequestsResolver
,
description:
'Merge
R
equests assigned to the user.'
description:
'Merge
r
equests assigned to the user.'
field
:review_requested_merge_requests
,
field
:review_requested_merge_requests
,
resolver:
Resolvers
::
ReviewRequestedMergeRequestsResolver
,
resolver:
Resolvers
::
ReviewRequestedMergeRequestsResolver
,
description:
'Merge
R
equests assigned to the user for review.'
description:
'Merge
r
equests assigned to the user for review.'
field
:snippets
,
field
:snippets
,
description:
'Snippets authored by the user.'
,
description:
'Snippets authored by the user.'
,
...
...
app/models/timelog.rb
View file @
86a3cab3
...
@@ -31,9 +31,9 @@ class Timelog < ApplicationRecord
...
@@ -31,9 +31,9 @@ class Timelog < ApplicationRecord
def
issuable_id_is_present
def
issuable_id_is_present
if
issue_id
&&
merge_request_id
if
issue_id
&&
merge_request_id
errors
.
add
(
:base
,
_
(
'Only Issue ID or
Merge R
equest ID is required'
))
errors
.
add
(
:base
,
_
(
'Only Issue ID or
merge r
equest ID is required'
))
elsif
issuable
.
nil?
elsif
issuable
.
nil?
errors
.
add
(
:base
,
_
(
'Issue or
Merge R
equest ID is required'
))
errors
.
add
(
:base
,
_
(
'Issue or
merge r
equest ID is required'
))
end
end
end
end
...
...
app/presenters/dev_ops_report/metric_presenter.rb
View file @
86a3cab3
...
@@ -38,7 +38,7 @@ module DevOpsReport
...
@@ -38,7 +38,7 @@ module DevOpsReport
),
),
Card
.
new
(
Card
.
new
(
metric:
subject
,
metric:
subject
,
title:
'Merge
R
equests'
,
title:
'Merge
r
equests'
,
description:
'per active user'
,
description:
'per active user'
,
feature:
'merge_requests'
,
feature:
'merge_requests'
,
blog:
'https://8thlight.com/blog/uncle-bob/2013/02/01/The-Humble-Craftsman.html'
,
blog:
'https://8thlight.com/blog/uncle-bob/2013/02/01/The-Humble-Craftsman.html'
,
...
...
app/views/groups/merge_requests.html.haml
View file @
86a3cab3
-
@can_bulk_update
=
can?
(
current_user
,
:admin_merge_request
,
@group
)
&&
@group
.
feature_available?
(
:group_bulk_edit
)
-
@can_bulk_update
=
can?
(
current_user
,
:admin_merge_request
,
@group
)
&&
@group
.
feature_available?
(
:group_bulk_edit
)
-
page_title
_
(
"Merge
R
equests"
)
-
page_title
_
(
"Merge
r
equests"
)
-
if
@merge_requests
&
.
size
==
0
-
if
@merge_requests
&
.
size
==
0
=
render
'shared/empty_states/merge_requests'
,
project_select_button:
true
=
render
'shared/empty_states/merge_requests'
,
project_select_button:
true
...
...
app/views/shared/milestones/_milestone.html.haml
View file @
86a3cab3
...
@@ -44,7 +44,7 @@
...
@@ -44,7 +44,7 @@
=
link_to
pluralize
(
milestone
.
total_issues_count
,
_
(
'Issue'
)),
issues_path
=
link_to
pluralize
(
milestone
.
total_issues_count
,
_
(
'Issue'
)),
issues_path
-
if
milestone
.
merge_requests_enabled?
-
if
milestone
.
merge_requests_enabled?
·
·
=
link_to
pluralize
(
milestone
.
merge_requests_visible_to_user
(
current_user
).
size
,
_
(
'Merge
R
equest'
)),
merge_requests_path
=
link_to
pluralize
(
milestone
.
merge_requests_visible_to_user
(
current_user
).
size
,
_
(
'Merge
r
equest'
)),
merge_requests_path
.float-lg-right.light
#{
milestone
.
percent_complete
}
% complete
.float-lg-right.light
#{
milestone
.
percent_complete
}
% complete
.col-sm-2
.col-sm-2
.milestone-actions.d-flex.justify-content-sm-start.justify-content-md-end
.milestone-actions.d-flex.justify-content-sm-start.justify-content-md-end
...
...
app/views/shared/milestones/_tabs.html.haml
View file @
86a3cab3
...
@@ -11,7 +11,7 @@
...
@@ -11,7 +11,7 @@
-
if
milestone
.
merge_requests_enabled?
-
if
milestone
.
merge_requests_enabled?
%li
.nav-item
%li
.nav-item
=
link_to
'#tab-merge-requests'
,
class:
'nav-link'
,
data:
{
toggle:
'tab'
,
endpoint:
milestone_tab_path
(
milestone
,
'merge_requests'
,
show_project_name:
show_project_name
)
}
do
=
link_to
'#tab-merge-requests'
,
class:
'nav-link'
,
data:
{
toggle:
'tab'
,
endpoint:
milestone_tab_path
(
milestone
,
'merge_requests'
,
show_project_name:
show_project_name
)
}
do
=
_
(
'Merge
R
equests'
)
=
_
(
'Merge
r
equests'
)
%span
.badge.badge-pill
=
milestone
.
merge_requests_visible_to_user
(
current_user
).
size
%span
.badge.badge-pill
=
milestone
.
merge_requests_visible_to_user
(
current_user
).
size
%li
.nav-item
%li
.nav-item
=
link_to
'#tab-participants'
,
class:
'nav-link'
,
data:
{
toggle:
'tab'
,
endpoint:
milestone_tab_path
(
milestone
,
'participants'
)
}
do
=
link_to
'#tab-participants'
,
class:
'nav-link'
,
data:
{
toggle:
'tab'
,
endpoint:
milestone_tab_path
(
milestone
,
'participants'
)
}
do
...
...
app/views/shared/projects/_project.html.haml
View file @
86a3cab3
...
@@ -90,7 +90,7 @@
...
@@ -90,7 +90,7 @@
-
if
show_merge_request_count?
(
disabled:
!
merge_requests
,
compact_mode:
compact_mode
)
-
if
show_merge_request_count?
(
disabled:
!
merge_requests
,
compact_mode:
compact_mode
)
=
link_to
project_merge_requests_path
(
project
),
=
link_to
project_merge_requests_path
(
project
),
class:
"d-none d-xl-flex align-items-center icon-wrapper merge-requests has-tooltip"
,
class:
"d-none d-xl-flex align-items-center icon-wrapper merge-requests has-tooltip"
,
title:
_
(
'Merge
R
equests'
),
data:
{
container:
'body'
,
placement:
'top'
}
do
title:
_
(
'Merge
r
equests'
),
data:
{
container:
'body'
,
placement:
'top'
}
do
=
sprite_icon
(
'git-merge'
,
size:
14
,
css_class:
'gl-mr-2'
)
=
sprite_icon
(
'git-merge'
,
size:
14
,
css_class:
'gl-mr-2'
)
=
number_with_delimiter
(
project
.
open_merge_requests_count
)
=
number_with_delimiter
(
project
.
open_merge_requests_count
)
-
if
show_issue_count?
(
disabled:
!
issues
,
compact_mode:
compact_mode
)
-
if
show_issue_count?
(
disabled:
!
issues
,
compact_mode:
compact_mode
)
...
...
danger/pipeline/Dangerfile
View file @
86a3cab3
...
@@ -3,9 +3,9 @@
...
@@ -3,9 +3,9 @@
MESSAGE
=
<<~
MESSAGE
MESSAGE
=
<<~
MESSAGE
## Pipeline Changes
## Pipeline Changes
This
Merge R
equest contains changes to the pipeline configuration for the GitLab project.
This
merge r
equest contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this
Merge R
equest on the following:
Please consider the effect of the changes in this
merge r
equest on the following:
- Effects on different [pipeline types](https://docs.gitlab.com/ee/development/pipelines.html#pipelines-for-merge-requests)
- Effects on different [pipeline types](https://docs.gitlab.com/ee/development/pipelines.html#pipelines-for-merge-requests)
- Effects on non-canonical projects:
- Effects on non-canonical projects:
- `gitlab-foss`
- `gitlab-foss`
...
...
doc/api/graphql/reference/index.md
View file @
86a3cab3
...
@@ -6543,8 +6543,8 @@ Representation of a GitLab user.
...
@@ -6543,8 +6543,8 @@ Representation of a GitLab user.
| Field | Type | Description |
| Field | Type | Description |
| ----- | ---- | ----------- |
| ----- | ---- | ----------- |
|
`assignedMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
R
equests assigned to the user. |
|
`assignedMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
r
equests assigned to the user. |
|
`authoredMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
R
equests authored by the user. |
|
`authoredMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
r
equests authored by the user. |
|
`avatarUrl`
|
[
`String`
](
#string
)
| URL of the user's avatar. |
|
`avatarUrl`
|
[
`String`
](
#string
)
| URL of the user's avatar. |
|
`bot`
|
[
`Boolean!`
](
#boolean
)
| Indicates if the user is a bot. |
|
`bot`
|
[
`Boolean!`
](
#boolean
)
| Indicates if the user is a bot. |
|
`callouts`
|
[
`UserCalloutConnection`
](
#usercalloutconnection
)
| User callouts that belong to the user. |
|
`callouts`
|
[
`UserCalloutConnection`
](
#usercalloutconnection
)
| User callouts that belong to the user. |
...
@@ -6556,7 +6556,7 @@ Representation of a GitLab user.
...
@@ -6556,7 +6556,7 @@ Representation of a GitLab user.
|
`name`
|
[
`String!`
](
#string
)
| Human-readable name of the user. |
|
`name`
|
[
`String!`
](
#string
)
| Human-readable name of the user. |
|
`projectMemberships`
|
[
`ProjectMemberConnection`
](
#projectmemberconnection
)
| Project memberships of the user. |
|
`projectMemberships`
|
[
`ProjectMemberConnection`
](
#projectmemberconnection
)
| Project memberships of the user. |
|
`publicEmail`
|
[
`String`
](
#string
)
| User's public email. |
|
`publicEmail`
|
[
`String`
](
#string
)
| User's public email. |
|
`reviewRequestedMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
R
equests assigned to the user for review. |
|
`reviewRequestedMergeRequests`
|
[
`MergeRequestConnection`
](
#mergerequestconnection
)
| Merge
r
equests assigned to the user for review. |
|
`snippets`
|
[
`SnippetConnection`
](
#snippetconnection
)
| Snippets authored by the user. |
|
`snippets`
|
[
`SnippetConnection`
](
#snippetconnection
)
| Snippets authored by the user. |
|
`starredProjects`
|
[
`ProjectConnection`
](
#projectconnection
)
| Projects starred by the user. |
|
`starredProjects`
|
[
`ProjectConnection`
](
#projectconnection
)
| Projects starred by the user. |
|
`state`
|
[
`UserState!`
](
#userstate
)
| State of the user. |
|
`state`
|
[
`UserState!`
](
#userstate
)
| State of the user. |
...
@@ -7833,7 +7833,7 @@ State of a GitLab merge request.
...
@@ -7833,7 +7833,7 @@ State of a GitLab merge request.
|
`all`
| All available. |
|
`all`
| All available. |
|
`closed`
| In closed state. |
|
`closed`
| In closed state. |
|
`locked`
| Discussion has been locked. |
|
`locked`
| Discussion has been locked. |
|
`merged`
| Merge
R
equest has been merged. |
|
`merged`
| Merge
r
equest has been merged. |
|
`opened`
| In open state. |
|
`opened`
| In open state. |
### `MergeStrategyEnum`
### `MergeStrategyEnum`
...
...
lib/banzai/filter/abstract_reference_filter.rb
View file @
86a3cab3
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
module
Banzai
module
Banzai
module
Filter
module
Filter
# Issues,
Merge R
equests, Snippets, Commits and Commit Ranges share
# Issues,
merge r
equests, Snippets, Commits and Commit Ranges share
# similar functionality in reference filtering.
# similar functionality in reference filtering.
class
AbstractReferenceFilter
<
ReferenceFilter
class
AbstractReferenceFilter
<
ReferenceFilter
include
CrossProjectReference
include
CrossProjectReference
...
...
lib/support/nginx/gitlab
View file @
86a3cab3
...
@@ -7,8 +7,8 @@
...
@@ -7,8 +7,8 @@
## CONTRIBUTING ##
## CONTRIBUTING ##
##################################
##################################
##
##
## If you change this file in a
Merge R
equest, please also create
## If you change this file in a
merge r
equest, please also create
## a
Merge R
equest on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests
## a
merge r
equest on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests
##
##
###################################
###################################
## configuration ##
## configuration ##
...
...
lib/support/nginx/gitlab-ssl
View file @
86a3cab3
...
@@ -11,8 +11,8 @@
...
@@ -11,8 +11,8 @@
## CONTRIBUTING ##
## CONTRIBUTING ##
##################################
##################################
##
##
## If you change this file in a
Merge R
equest, please also create
## If you change this file in a
merge r
equest, please also create
## a
Merge R
equest on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests
## a
merge r
equest on https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests
##
##
###################################
###################################
## configuration ##
## configuration ##
...
...
locale/gitlab.pot
View file @
86a3cab3
...
@@ -17282,7 +17282,7 @@ msgstr ""
...
@@ -17282,7 +17282,7 @@ msgstr ""
msgid "Issue label"
msgid "Issue label"
msgstr ""
msgstr ""
msgid "Issue or
Merge R
equest ID is required"
msgid "Issue or
merge r
equest ID is required"
msgstr ""
msgstr ""
msgid "Issue published on status page."
msgid "Issue published on status page."
...
@@ -21776,7 +21776,7 @@ msgstr ""
...
@@ -21776,7 +21776,7 @@ msgstr ""
msgid "Only 1 appearances row can exist"
msgid "Only 1 appearances row can exist"
msgstr ""
msgstr ""
msgid "Only Issue ID or
Merge R
equest ID is required"
msgid "Only Issue ID or
merge r
equest ID is required"
msgstr ""
msgstr ""
msgid "Only Project Members"
msgid "Only Project Members"
...
...
spec/features/dashboard/milestones_spec.rb
View file @
86a3cab3
...
@@ -30,7 +30,7 @@ RSpec.describe 'Dashboard > Milestones' do
...
@@ -30,7 +30,7 @@ RSpec.describe 'Dashboard > Milestones' do
expect
(
current_path
).
to
eq
dashboard_milestones_path
expect
(
current_path
).
to
eq
dashboard_milestones_path
expect
(
page
).
to
have_content
(
milestone
.
title
)
expect
(
page
).
to
have_content
(
milestone
.
title
)
expect
(
page
).
to
have_content
(
group
.
name
)
expect
(
page
).
to
have_content
(
group
.
name
)
expect
(
first
(
'.milestone'
)).
to
have_content
(
'Merge
R
equests'
)
expect
(
first
(
'.milestone'
)).
to
have_content
(
'Merge
r
equests'
)
end
end
describe
'new milestones dropdown'
,
:js
do
describe
'new milestones dropdown'
,
:js
do
...
...
spec/features/groups/milestone_spec.rb
View file @
86a3cab3
...
@@ -133,7 +133,7 @@ RSpec.describe 'Group milestones' do
...
@@ -133,7 +133,7 @@ RSpec.describe 'Group milestones' do
href:
project_issues_path
(
project
,
milestone_title:
'v1.0'
)
href:
project_issues_path
(
project
,
milestone_title:
'v1.0'
)
)
)
expect
(
page
).
to
have_link
(
expect
(
page
).
to
have_link
(
'0 Merge
R
equests'
,
'0 Merge
r
equests'
,
href:
project_merge_requests_path
(
project
,
milestone_title:
'v1.0'
)
href:
project_merge_requests_path
(
project
,
milestone_title:
'v1.0'
)
)
)
expect
(
page
).
to
have_link
(
expect
(
page
).
to
have_link
(
...
@@ -145,7 +145,7 @@ RSpec.describe 'Group milestones' do
...
@@ -145,7 +145,7 @@ RSpec.describe 'Group milestones' do
href:
issues_group_path
(
group
,
milestone_title:
'GL-113'
)
href:
issues_group_path
(
group
,
milestone_title:
'GL-113'
)
)
)
expect
(
page
).
to
have_link
(
expect
(
page
).
to
have_link
(
'0 Merge
R
equests'
,
'0 Merge
r
equests'
,
href:
merge_requests_group_path
(
group
,
milestone_title:
'GL-113'
)
href:
merge_requests_group_path
(
group
,
milestone_title:
'GL-113'
)
)
)
end
end
...
@@ -179,7 +179,7 @@ RSpec.describe 'Group milestones' do
...
@@ -179,7 +179,7 @@ RSpec.describe 'Group milestones' do
it
'renders the merge requests tab'
do
it
'renders the merge requests tab'
do
within
(
'.js-milestone-tabs'
)
do
within
(
'.js-milestone-tabs'
)
do
click_link
(
'Merge
R
equests'
)
click_link
(
'Merge
r
equests'
)
end
end
within
(
'#tab-merge-requests'
)
do
within
(
'#tab-merge-requests'
)
do
...
...
spec/features/milestones/user_views_milestone_spec.rb
View file @
86a3cab3
...
@@ -98,7 +98,7 @@ RSpec.describe "User views milestone" do
...
@@ -98,7 +98,7 @@ RSpec.describe "User views milestone" do
visit
(
project_milestone_path
(
project
,
milestone
))
visit
(
project_milestone_path
(
project
,
milestone
))
within
(
'.js-milestone-tabs'
)
do
within
(
'.js-milestone-tabs'
)
do
click_link
(
'Merge
R
equests'
)
click_link
(
'Merge
r
equests'
)
end
end
wait_for_requests
wait_for_requests
...
@@ -116,7 +116,7 @@ RSpec.describe "User views milestone" do
...
@@ -116,7 +116,7 @@ RSpec.describe "User views milestone" do
visit
(
group_milestone_path
(
group
,
group_milestone
))
visit
(
group_milestone_path
(
group
,
group_milestone
))
within
(
'.js-milestone-tabs'
)
do
within
(
'.js-milestone-tabs'
)
do
click_link
(
'Merge
R
equests'
)
click_link
(
'Merge
r
equests'
)
end
end
expect
(
page
.
find
(
'#tab-merge-requests'
)).
to
have_text
(
project
.
name
)
expect
(
page
.
find
(
'#tab-merge-requests'
)).
to
have_text
(
project
.
name
)
...
...
spec/features/milestones/user_views_milestones_spec.rb
View file @
86a3cab3
...
@@ -18,7 +18,7 @@ RSpec.describe "User views milestones" do
...
@@ -18,7 +18,7 @@ RSpec.describe "User views milestones" do
expect
(
page
).
to
have_content
(
milestone
.
title
)
expect
(
page
).
to
have_content
(
milestone
.
title
)
.
and
have_content
(
milestone
.
expires_at
)
.
and
have_content
(
milestone
.
expires_at
)
.
and
have_content
(
"Issues"
)
.
and
have_content
(
"Issues"
)
.
and
have_content
(
"Merge
R
equests"
)
.
and
have_content
(
"Merge
r
equests"
)
end
end
context
"with issues"
,
:js
do
context
"with issues"
,
:js
do
...
@@ -80,7 +80,6 @@ RSpec.describe "User views milestones with no MR" do
...
@@ -80,7 +80,6 @@ RSpec.describe "User views milestones with no MR" do
expect
(
page
).
to
have_content
(
milestone
.
title
)
expect
(
page
).
to
have_content
(
milestone
.
title
)
.
and
have_content
(
milestone
.
expires_at
)
.
and
have_content
(
milestone
.
expires_at
)
.
and
have_content
(
"Issues"
)
.
and
have_content
(
"Issues"
)
.
and
have_no_content
(
"Merge Requests"
)
end
end
it
"opens milestone"
do
it
"opens milestone"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment