Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
87c18617
Commit
87c18617
authored
Jul 15, 2017
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move EE specific code to their respective places
parent
5d4250ae
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
40 additions
and
40 deletions
+40
-40
app/models/ee/merge_request.rb
app/models/ee/merge_request.rb
+8
-0
app/models/merge_request.rb
app/models/merge_request.rb
+0
-8
spec/models/ee/user_spec.rb
spec/models/ee/user_spec.rb
+32
-0
spec/models/user_spec.rb
spec/models/user_spec.rb
+0
-32
No files found.
app/models/ee/merge_request.rb
View file @
87c18617
...
...
@@ -8,6 +8,9 @@ module EE
has_many
:approvals
,
dependent: :delete_all
# rubocop:disable Cop/ActiveRecordDependent
has_many
:approvers
,
as: :target
,
dependent: :delete_all
# rubocop:disable Cop/ActiveRecordDependent
has_many
:approver_groups
,
as: :target
,
dependent: :delete_all
# rubocop:disable Cop/ActiveRecordDependent
delegate
:codeclimate_artifact
,
to: :head_pipeline
,
prefix: :head
,
allow_nil:
true
delegate
:codeclimate_artifact
,
to: :base_pipeline
,
prefix: :base
,
allow_nil:
true
end
def
ff_merge_possible?
...
...
@@ -64,5 +67,10 @@ module EE
def
supports_weight?
false
end
def
has_codeclimate_data?
!!
(
head_codeclimate_artifact
&
.
success?
&&
base_codeclimate_artifact
&
.
success?
)
end
end
end
app/models/merge_request.rb
View file @
87c18617
...
...
@@ -38,9 +38,6 @@ class MergeRequest < ActiveRecord::Base
delegate
:commits
,
:real_size
,
:commit_shas
,
:commits_count
,
to: :merge_request_diff
,
prefix:
nil
delegate
:codeclimate_artifact
,
to: :head_pipeline
,
prefix: :head
,
allow_nil:
true
delegate
:codeclimate_artifact
,
to: :base_pipeline
,
prefix: :base
,
allow_nil:
true
# When this attribute is true some MR validation is ignored
# It allows us to close or modify broken merge requests
attr_accessor
:allow_broken
...
...
@@ -952,9 +949,4 @@ class MergeRequest < ActiveRecord::Base
def
base_pipeline
@base_pipeline
||=
project
.
pipelines
.
find_by
(
sha:
merge_request_diff
&
.
base_commit_sha
)
end
def
has_codeclimate_data?
!!
(
head_codeclimate_artifact
&
.
success?
&&
base_codeclimate_artifact
&
.
success?
)
end
end
spec/models/ee/user_spec.rb
View file @
87c18617
...
...
@@ -73,4 +73,36 @@ describe EE::User, models: true do
expect
(
user
.
full_private_access?
).
to
be_truthy
end
end
describe
'#forget_me!'
do
subject
{
create
(
:user
,
remember_created_at:
Time
.
now
)
}
it
'clears remember_created_at'
do
subject
.
forget_me!
expect
(
subject
.
reload
.
remember_created_at
).
to
be_nil
end
it
'does not clear remember_created_at when in a Geo secondary node'
do
allow
(
Gitlab
::
Geo
).
to
receive
(
:secondary?
)
{
true
}
expect
{
subject
.
forget_me!
}.
not_to
change
(
subject
,
:remember_created_at
)
end
end
describe
'#remember_me!'
do
subject
{
create
(
:user
,
remember_created_at:
nil
)
}
it
'updates remember_created_at'
do
subject
.
remember_me!
expect
(
subject
.
reload
.
remember_created_at
).
not_to
be_nil
end
it
'does not update remember_created_at when in a Geo secondary node'
do
allow
(
Gitlab
::
Geo
).
to
receive
(
:secondary?
)
{
true
}
expect
{
subject
.
remember_me!
}.
not_to
change
(
subject
,
:remember_created_at
)
end
end
end
spec/models/user_spec.rb
View file @
87c18617
...
...
@@ -2054,36 +2054,4 @@ describe User, models: true do
user
.
invalidate_merge_request_cache_counts
end
end
describe
'#forget_me!'
do
subject
{
create
(
:user
,
remember_created_at:
Time
.
now
)
}
it
'clears remember_created_at'
do
subject
.
forget_me!
expect
(
subject
.
reload
.
remember_created_at
).
to
be_nil
end
it
'does not clear remember_created_at when in a Geo secondary node'
do
allow
(
Gitlab
::
Geo
).
to
receive
(
:secondary?
)
{
true
}
expect
{
subject
.
forget_me!
}.
not_to
change
(
subject
,
:remember_created_at
)
end
end
describe
'#remember_me!'
do
subject
{
create
(
:user
,
remember_created_at:
nil
)
}
it
'updates remember_created_at'
do
subject
.
remember_me!
expect
(
subject
.
reload
.
remember_created_at
).
not_to
be_nil
end
it
'does not update remember_created_at when in a Geo secondary node'
do
allow
(
Gitlab
::
Geo
).
to
receive
(
:secondary?
)
{
true
}
expect
{
subject
.
remember_me!
}.
not_to
change
(
subject
,
:remember_created_at
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment