Commit 87d830f3 authored by Avielle Wolfe's avatar Avielle Wolfe

Add 10s and 15s buckets to step histogram

p99 of pipeline creation is generally between 5s and 20s, so adding
additional buckets between that will give us needed insight into step
creation duration.
parent 9e573001
...@@ -18,7 +18,7 @@ module Gitlab ...@@ -18,7 +18,7 @@ module Gitlab
description = step.gsub('gitlab_ci_', '').tr('_', ' ') description = step.gsub('gitlab_ci_', '').tr('_', ' ')
comment = "Duration of the #{description}" comment = "Duration of the #{description}"
labels = {} labels = {}
buckets = [0.01, 0.05, 0.1, 0.5, 1.0, 2.0, 5.0, 20.0, 50.0, 240.0] buckets = [0.01, 0.05, 0.1, 0.5, 1.0, 2.0, 5.0, 10.0, 15.0, 20.0, 50.0, 240.0]
::Gitlab::Metrics.histogram(name, comment, labels, buckets) ::Gitlab::Metrics.histogram(name, comment, labels, buckets)
end end
......
...@@ -12,7 +12,7 @@ RSpec.describe ::Gitlab::Ci::Pipeline::Metrics do ...@@ -12,7 +12,7 @@ RSpec.describe ::Gitlab::Ci::Pipeline::Metrics do
:gitlab_ci_pipeline_chain_build_duration_seconds, :gitlab_ci_pipeline_chain_build_duration_seconds,
'Duration of the pipeline chain build', 'Duration of the pipeline chain build',
{}, {},
[0.01, 0.05, 0.1, 0.5, 1.0, 2.0, 5.0, 20.0, 50.0, 240.0] [0.01, 0.05, 0.1, 0.5, 1.0, 2.0, 5.0, 10.0, 15.0, 20.0, 50.0, 240.0]
) )
described_class.pipeline_creation_step_duration_histogram(step) described_class.pipeline_creation_step_duration_histogram(step)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment