Commit 88746f53 authored by Luke Duncalfe's avatar Luke Duncalfe

CE-specific changes to allow design Todos

CE-specific changes for:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15129Co-Authored-By: default avatarAlex Kalderimis <akalderimis@gitlab.com>
Co-Authored-By: default avatarLuke Duncalfe <lduncalfe@eml.cc>
parent 7c9fb3c6
......@@ -26,7 +26,7 @@ module TodosHelper
end
def todo_target_link(todo)
text = raw("#{todo.target_type.titleize.downcase} ") +
text = raw(todo_target_type_name(todo) + ' ') +
if todo.for_commit?
content_tag(:span, todo.target_reference, class: 'commit-sha')
else
......@@ -36,23 +36,34 @@ module TodosHelper
link_to text, todo_target_path(todo), class: 'has-tooltip', title: todo.target.title
end
def todo_target_type_name(todo)
todo.target_type.titleize.downcase
end
def todo_target_path(todo)
return unless todo.target.present?
anchor = dom_id(todo.note) if todo.note.present?
path_options = todo_target_path_options(todo)
if todo.for_commit?
project_commit_path(todo.project,
todo.target, anchor: anchor)
project_commit_path(todo.project, todo.target, path_options)
else
path = [todo.parent, todo.target]
path.unshift(:pipelines) if todo.build_failed?
polymorphic_path(path, anchor: anchor)
polymorphic_path(path, path_options)
end
end
def todo_target_path_options(todo)
{ anchor: todo_target_path_anchor(todo) }
end
def todo_target_path_anchor(todo)
dom_id(todo.note) if todo.note.present?
end
def todo_target_state_pill(todo)
return unless show_todo_state?(todo)
......
......@@ -505,7 +505,7 @@ constraints(::Constraints::ProjectUrlConstrainer.new) do
get :discussions, format: :json
Gitlab.ee do
get 'designs(/*vueroute)', to: 'issues#show', format: false
get 'designs(/*vueroute)', to: 'issues#show', as: :designs, format: false
end
end
......
......@@ -13,6 +13,13 @@ module API
'issues' => ->(iid) { find_project_issue(iid) }
}.freeze
helpers do
# EE::API::Todos would override this method
def find_todos
TodosFinder.new(current_user, params).execute
end
end
params do
requires :id, type: String, desc: 'The ID of a project'
end
......@@ -41,10 +48,6 @@ module API
resource :todos do
helpers do
def find_todos
TodosFinder.new(current_user, params).execute
end
def issuable_and_awardable?(type)
obj_type = Object.const_get(type)
......@@ -107,3 +110,5 @@ module API
end
end
end
API::Todos.prepend_if_ee('EE::API::Todos')
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment