Commit 89222e3e authored by Sarah Groff Hennigh-Palermo's avatar Sarah Groff Hennigh-Palermo Committed by Phil Hughes

Add check in linked graphs

parent 2c361e2b
...@@ -3,7 +3,7 @@ import getPipelineDetails from 'shared_queries/pipelines/get_pipeline_details.qu ...@@ -3,7 +3,7 @@ import getPipelineDetails from 'shared_queries/pipelines/get_pipeline_details.qu
import { LOAD_FAILURE } from '../../constants'; import { LOAD_FAILURE } from '../../constants';
import { reportToSentry } from '../../utils'; import { reportToSentry } from '../../utils';
import { listByLayers } from '../parsing_utils'; import { listByLayers } from '../parsing_utils';
import { ONE_COL_WIDTH, UPSTREAM, LAYER_VIEW } from './constants'; import { ONE_COL_WIDTH, UPSTREAM, LAYER_VIEW, STAGE_VIEW } from './constants';
import LinkedPipeline from './linked_pipeline.vue'; import LinkedPipeline from './linked_pipeline.vue';
import { import {
getQueryHeaders, getQueryHeaders,
...@@ -80,6 +80,9 @@ export default { ...@@ -80,6 +80,9 @@ export default {
graphPosition() { graphPosition() {
return this.isUpstream ? 'left' : 'right'; return this.isUpstream ? 'left' : 'right';
}, },
graphViewType() {
return this.currentPipeline?.usesNeeds ? this.viewType : STAGE_VIEW;
},
isUpstream() { isUpstream() {
return this.type === UPSTREAM; return this.type === UPSTREAM;
}, },
...@@ -223,7 +226,7 @@ export default { ...@@ -223,7 +226,7 @@ export default {
:pipeline-layers="getPipelineLayers(pipeline.id)" :pipeline-layers="getPipelineLayers(pipeline.id)"
:show-links="showLinks" :show-links="showLinks"
:is-linked-pipeline="true" :is-linked-pipeline="true"
:view-type="viewType" :view-type="graphViewType"
/> />
</div> </div>
</li> </li>
......
...@@ -121,6 +121,26 @@ describe('Linked Pipelines Column', () => { ...@@ -121,6 +121,26 @@ describe('Linked Pipelines Column', () => {
}); });
}); });
describe('when graph does not use needs', () => {
beforeEach(() => {
const nonNeedsResponse = { ...wrappedPipelineReturn };
nonNeedsResponse.data.project.pipeline.usesNeeds = false;
createComponentWithApollo({
props: {
viewType: LAYER_VIEW,
},
getPipelineDetailsHandler: jest.fn().mockResolvedValue(nonNeedsResponse),
mountFn: mount,
});
});
it('shows the stage view, even when the main graph view type is layers', async () => {
await clickExpandButtonAndAwaitTimers();
expect(findPipelineGraph().props('viewType')).toBe(STAGE_VIEW);
});
});
describe('downstream', () => { describe('downstream', () => {
describe('when successful', () => { describe('when successful', () => {
beforeEach(() => { beforeEach(() => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment