Commit 89e3a62a authored by Rémy Coutable's avatar Rémy Coutable

Delete examples that only pass on retries

These examples were testing the case where a feature flag for the
feature weas disabled, but licensed features aren't dependent on feature
flags so they were always failing on first try.

Interestingly, they passed on retry, which might be a side-effect of
rspec-retry but they should never have passed.

This could be reproduced by

```
bin/rspec './ee/spec/controllers/projects_controller_spec.rb[1:4:6:2:1]'

RETRIES=1 bin/rspec './ee/spec/controllers/projects_controller_spec.rb[1:4:6:2:1]'
```
Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent e3dcf1c2
......@@ -293,18 +293,6 @@ RSpec.describe ProjectsController do
expect(project.reload.merge_pipelines_enabled).to be_truthy
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(merge_pipelines: false)
end
it 'does not update the attribute' do
request
expect(project.reload.merge_pipelines_enabled).to be_falsy
end
end
context 'when license is not sufficient' do
before do
stub_licensed_features(merge_pipelines: false)
......@@ -335,18 +323,6 @@ RSpec.describe ProjectsController do
expect(project.merge_trains_enabled).to be_truthy
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(merge_trains: false)
end
it 'does not update the attribute' do
request
expect(project.merge_trains_enabled).to be_falsy
end
end
context 'when license is not sufficient' do
before do
stub_licensed_features(merge_trains: false)
......@@ -377,18 +353,6 @@ RSpec.describe ProjectsController do
expect(project.reload.auto_rollback_enabled).to be_truthy
end
context 'when feature flag is disabled' do
before do
stub_feature_flags(auto_rollback: false)
end
it 'does not update the attribute' do
request
expect(project.reload.auto_rollback_enabled).to be_falsy
end
end
context 'when license is not sufficient' do
before do
stub_licensed_features(auto_rollback: false)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment