Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8a32e643
Commit
8a32e643
authored
Mar 23, 2021
by
kkoji
Committed by
Lin Jen-Shin
Mar 23, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed an issue where the link commit message did not end with a newline
parent
960b6409
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
changelogs/unreleased/26522-commit-message-link-line-break.yml
...elogs/unreleased/26522-commit-message-link-line-break.yml
+5
-0
lib/banzai/filter/commit_trailers_filter.rb
lib/banzai/filter/commit_trailers_filter.rb
+1
-1
spec/lib/banzai/filter/commit_trailers_filter_spec.rb
spec/lib/banzai/filter/commit_trailers_filter_spec.rb
+6
-0
No files found.
changelogs/unreleased/26522-commit-message-link-line-break.yml
0 → 100644
View file @
8a32e643
---
title
:
Fixed an issue where the link commit message did not end with a newline
merge_request
:
49086
author
:
Kazuya Kojima
type
:
fixed
lib/banzai/filter/commit_trailers_filter.rb
View file @
8a32e643
...
@@ -36,7 +36,7 @@ module Banzai
...
@@ -36,7 +36,7 @@ module Banzai
next
if
html
==
content
next
if
html
==
content
node
.
replace
(
html
)
node
.
replace
(
"
\n\n
#{
html
}
"
)
end
end
doc
doc
...
...
spec/lib/banzai/filter/commit_trailers_filter_spec.rb
View file @
8a32e643
...
@@ -139,6 +139,12 @@ RSpec.describe Banzai::Filter::CommitTrailersFilter do
...
@@ -139,6 +139,12 @@ RSpec.describe Banzai::Filter::CommitTrailersFilter do
end
end
context
"structure"
do
context
"structure"
do
it
'starts with two newlines to separate with actual commit message'
do
doc
=
filter
(
commit_message_html
)
expect
(
doc
.
xpath
(
'pre'
).
text
).
to
start_with
(
"
\n\n
"
)
end
it
'preserves the commit trailer structure'
do
it
'preserves the commit trailer structure'
do
doc
=
filter
(
commit_message_html
)
doc
=
filter
(
commit_message_html
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment